fix(site): finish the Pages review follow-ups - #209
Merged
Merged
Conversation
The first pass left the landing page cutting 19 skill and rule descriptions mid-clause, listing all 28 showcase props (10k px of page), and the gallery with three identical links per card, a zoom overlay that let focus escape behind it, and no 404 page for renamed examples. - build_site: descriptions shown whole up to 340 chars, else cut at a sentence boundary; backtick spans render as <code>; showcase honors featured_rank like examples; generate a root-absolute 404.html - showcase/gallery.json: feature six varied pieces on the landing page - build_gallery: zoom overlay is a <dialog> (focus trap, Esc, focus return, Close button); the image link on each card leaves the tab order; "View" links carry the entry name; the Tags toggle names the active tag on narrow screens; footer names the right source JSON; README content is substituted last so it can't hit other placeholders - both templates declare color-scheme: dark Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #208, finishing the Pages review. The landing page cut 19 skill and rule descriptions mid-clause and listed all 28 showcase props, making the page 10,100px tall. On the gallery, each card had three identical links, the zoom overlay let focus escape behind it, and there was no 404 page for renamed examples.
Type
featfix— site generator and landing template correctionsdocs/chore/ci/refactorChanges
Landing page (
scripts/site/)`backtick`spans in descriptions render as<code>.featured_rank, as examples already do. Six pieces are featured inshowcase/gallery.json: stone-well, market-stall, wall-torch, cart, park-bench, stone-archway. The header reads "6 of 28 pieces". Page height: 10,136 → ~7,030px at 1440px wide.404.html.j2is rendered bybuild_site.pyintodocs/404.html(gitignored, likeindex.html). Links are root-absolute, derived fromsite.jsoncanonical, because Pages serves it at any depth.color-scheme: darkis set, which fixes the light native scrollbar on the mobile clone box.Gallery (
scripts/build_gallery.py, 80 regenerated pages)<dialog>opened withshowModal(). It traps focus, closes on Esc and returns focus to the hero, and has a Close button. A click anywhere still closes it.tabindex="-1" aria-hidden="true", since the title link already goes to the same page. The "View example" links now include the entry name for screen readers.#tag=link is visibly filtered.showcase/gallery.jsonon showcase pages, both files on the index.__CONTENT__is substituted last, so README or source text can never hit another placeholder.Evidence
build_site.pyandbuild_gallery.py, serveddocs/, and drove it with Playwright:openafter click; focus on.lightbox-closeand still inside after 4 Tabs; closed after Esc with focus back on#heroZoom; closed after a click.#tag=showcaseshows "Tags: showcase" and "28 OF 79". Clearing the tag resets the toggle to "Tags". Every.card-mediahastabIndex === -1. The first card link reads "View example swatch-grid →". No horizontal overflow.color-schemeisdark./Blender-Developer-Tools/on Pages.<em>, 0 raw pipe rows.Checklist
showcase/gallery.jsongains onlyfeatured_rankkeys; a JSON round-trip was byte-identical before the edit.Signed-off-by:present.Test plan
python scripts/site/build_site.py --repo-root . --out docs && python scripts/build_gallery.py, then servedocs/and check/,/404.html,/gallery/#tag=showcase(at 375px) and/gallery/stone-archway/(zoom dialog).Still open
docs/gallery/contact-sheets/(3.4 MB),technical-audit.md,new-example-prompt.md,VISUAL-STYLE.mdandgallery/DESIGN_NOTES.mdstay publicly served is left to the owner.🤖 Generated with Claude Code