fix(tests): stop exempting cart, hay-bale and stone-well from the falsifier-table check - #210
Merged
Merged
Conversation
…sifier-table check All three READMEs gained falsifier tables in #205 and #206, and the static checker already parses them (28 pieces, 181 falsifiers), but they stayed listed in KNOWN_UNDOCUMENTED. That exemption is now a hole: if one of those tables were deleted, the checker would skip the piece silently instead of failing it. Every falsifier was run, not read: the runtime mode reports 19/19 exits matching their declared budgets on Blender 5.2.1, and a direct sweep gives the same 19 codes on 4.5.11. Closes #203 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #203. The three pieces it tracks (
cart,hay-bale,stone-well) already gained falsifier tables in #205 and #206, and the static checker parses them, but they stayed inKNOWN_UNDOCUMENTED. That exemption is now a hole: deleting one of those tables would make the checker skip the piece instead of failing it. This PR empties the set.Type
featfix— test correctnessdocs/chore/ci/refactorEvidence
E:\Blender-Developer-Tools\.scratch\blender-5.2.1-windows-x64\blender.exe(reportsBlender 5.2.1 LTS):python tests/check_falsifier_targets.py --run <that> --only cart --only hay-bale --only stone-wellprints 19/19ok, e.g.cart --sink-tyre: want 18, got 18,stone-well --turn-posts: want 19, got 19....\blender-4.5.11-windows-x64\blender.exe(reportsBlender 4.5.11 LTS): a direct sweep of the same 19 flags gives identical exit codes. The clean run exits 0 for all three pieces on both versions.ERROR: tyre seat depth band [0.00900, 0.00900] outside [0.003, 0.0055] ... (--sink-tyre is the designed fail ...).falsifier-target checks passed: 181 falsifier(s) across 28 showcase piece(s).with no backfill note.| Flag | Target budget | Exit |→| Switch | Target budget | Result |). The checker then exits 1 withERROR: showcase/cart: no falsifier table mapping flag to target budget to exit code. Before this PR, that case was skipped silently. I then restored the header.Checklist
Signed-off-by:present.Test plan
python tests/check_falsifier_targets.py(static), plus the--runcommand above.🤖 Generated with Claude Code