fix(showcase): bring 19 previews to the 1200x675 spec and enforce hero/preview sizes - #217
Merged
Merged
Conversation
…o/preview sizes CLAUDE.md fixes preview webps at 1200x675 and heroes at 1280x720. All 51 example previews conformed, but 19 of 28 showcase previews shipped at the hero size, and nothing checked either. - Downscale the 19 (same 16:9 aspect, Lanczos, webp q90); no re-render. - tests/check_gallery_images.py asserts both sizes for every gallery.json entry. Stdlib only: it parses the WebP RIFF header (VP8, VP8L, VP8X), so it runs on the bare Validate runner. Its parser agrees with Pillow on all 158 images. Closes #214 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> # Conflicts: # .github/workflows/validate.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #214. CLAUDE.md fixes preview webps at 1200×675 and heroes at 1280×720. All 51 example previews conformed, but 19 of 28 showcase previews shipped at the hero size, and nothing checked either size.
Type
featfix— content integrity plus a new checkdocs/chore/ci/refactorChanges
tests/check_gallery_images.py, wired into Validate. It asserts hero 1280×720 and preview 1200×675 for every entry in both gallery.json files. It uses only the standard library, parsing the WebP RIFF header (VP8 / VP8L / VP8X chunks), so it needs no Pillow on the runner.Evidence
stone-archway: preview showcase/stone-archway/preview.webp is 1280x720, expected 1200x675. After it:gallery image sizes ok: 158 image(s) across both gallery.json files., exit 0.webp_size()agrees with Pillow'sImage.sizeon all 158 hero and preview files (0 disagreements).python scripts/build_gallery.pyleavesdocs/gallery/untouched. The site does not serve previews.Checklist
Signed-off-by:present.🤖 Generated with Claude Code