fix(examples): resolve --output against the working directory in three render paths - #223
Merged
Merged
Conversation
…e render paths damped-track-aim, gn-sdf-remesh and turntable passed --output straight to scene.render.filepath. Blender resolves a relative filepath against the blend-file directory, which for a --background run with no .blend is the drive root, so the documented `-- --output aim.png` wrote to C:\ and the script exited with its "no file" code (10, 4, 4). Every other example already applies os.path.abspath. Closes #222 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
8 tasks
…ne the source) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #222.
damped-track-aim,gn-sdf-remeshandturntablepassed--outputstraight toscene.render.filepath. Blender resolves a relative path against the blend-file directory; a--backgroundrun has no.blend, so the path resolves against the drive root. Their documented commands (-- --output aim.png…) wrote toC:\and exited non-zero. The fix ispath = os.path.abspath(path)before the assignment, as every other example already does.Type
featfix— broken documented render commanddocs/chore/ci/refactorEvidence
live-run-proven with
E:\Blender-Developer-Tools\.scratch\blender-5.2.1-windows-x64\blender.exe(reportsBlender 5.2.1 LTS) and...\blender-4.5.11-windows-x64\blender.exe(reportsBlender 4.5.11 LTS):--output, 5.2.1)Saved: 'C:\.scratch\...'Saved: 'C:\.scratch\relprobe\...'Saved: 'C:\.scratch\relprobe\...'After the fix, nothing is written under
C:\.scratch\.The "before" column is the falsification: the relative-path failure is reproducible without the fix and gone with it.
Check path unchanged: the edit is inside
render_stillonly. Smoke never passes--outputto these three; this PR's smoke jobs cover the check path.Checklist
Signed-off-by:present.🤖 Generated with Claude Code