fix: water-trough, gn-sdf-remesh and eval-mesh-datablock-name quality pass - #229
Merged
TMHSDigital merged 4 commits intoSep 23, 2026
Merged
Conversation
… the water The ends were open U-bands and the water's end face showed where a board belongs; the piece read as a hammock. Ends are now solid boards on the hull's outer arc, and a containment budget casts rays outward from across each water end face (exit 18, --open-ends). --short-legs now stretches the legs to the floor instead of letting the piece re-ground, keeping its AABB still. Per-plank tone and grain, darker water at half fill, wider straps. The temp glTF export is removed after measuring. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
…de under edge cages Render path only. The check, its assertions and exit codes are unchanged. Both tori are grounded on their measured bottoms. docs/gallery/index.html also carries the water-trough card alt from the previous commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
…why name tests never worked Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
… envelopes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
TMHSDigital
deleted the
fix/quality-pass-trough-sdf-remesh-datablock-name
branch
September 23, 2026 15:28
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass: three items, one per track. Everything below comes from live runs on
.scratch/blender-{4.5.11,5.1.2,5.2.1}-windows-x64/blender.exe, which report 4.5.11 LTS / 5.1.2 / 5.2.1 LTS, unless it is labelled inspection.Every showcase piece had already had one pass. water-trough was picked from a thumbnail grid of all 28 heroes as the one that read worst: a hammock or sun lounger, not a trough.
A —
showcase/water-troughTook 3 inspection rounds, plus hero iterations on the water surface in round 2. Each round covered six orthos, two three-quarters, clay, wireframe, 8 close-ups (both ends, strap, leg-to-hull, stretchers, shoe, water surface, water end) and ground contact.
Defects
--short-legssat 0.4 mm inside the bbox tolerance. Found by the after-matrix: a 1.5 mm model change tipped it from exit 16 to exit 8 on all three binaries. The falsifier lifted the shoes, so the whole piece re-grounded on the legs and the AABB shrank about 10 mm against a 10 mm tolerance..glbexport leaked into the working directory.Fixes, and why each is structural
add_end_boardbuilds a solid end whose bottom is the hull's own outer arc (r_out + END_OVERHANG, sameA_SPAN) and whose top is level at the band's inner rim. It is all quads (vertical strips from each arc point), so no n-gon to fan. The existing--box-endsrim-span budget still separates it from a bounding-box slab (rim span 0.021 against 0.161). The bevel now skips flat strip seams.paint_plankswrites a seededPlankToneand each shell's principal axis asGrainDir; the wood shader stretches grain along it.STRAP_W28 → 40 mm.WATER_FILL0.68 → 0.50.--short-legseach leg's foot now stretches down to the floor, so the legs plant, the shoes float, and the envelope moves 1.6 mm (margin 8.4 mm). The falsifier was fixed, not the band.New budget. Measured identically on 4.5.11, 5.1.2 and 5.2.1.
END_TRe-fitted around the measurements: base tris 3300–4000 → 2800–3500, and declared outer AABB z 0.504 → 0.5055 (tolerance unchanged at 0.01).
Triangles: 3700 → 3124. Solid boards close the section with fewer faces than the open bands. Collider 64 and LOD ratios are unchanged in kind. Same-binary determinism: two runs on 5.2.1 match on every measured line.
Falsifier:
--open-endsrestores the U-bands, all 66 rays miss → 18 on all three binaries.tests/check_falsifier_targets.pypasses (185 falsifiers).Existing exit codes, before → after, identical on 4.5.11, 5.1.2 and 5.2.1: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--short-legs16→16 (after fix 6),--box-ends17→17,--float-strap18→18,--narrow-hull19→19. The baseline was taken with the piece stashed back tomain.Hero re-rendered on 5.2.1 through
scripts/render_hero.py.check_framingruns withoutdeviation=: fill y 0.794, min margin 0.044. Contact sheet:docs/gallery/contact-sheets/water-trough-contact-sheet.webp.Still weak: the water is a flat, featureless plane. It reads as water only from context.
B —
examples/gn-sdf-remeshPresentation changes (render path only):
bpy.data.meshes.new_from_object; a live copy of the tree re-applied its Set Material and painted the cage crimson. Alone, the remeshed torus read as a glossy inner tube with blocky highlights, and nothing said "remeshed". Now ring topology in, voxel topology out.build()centres the torus at z 0.55 with a 0.5 minor radius, so the old still hovered 5 cm over the floor, visible in the clay pass.build()and the checks are untouched. The faceting stays: it is the evidence.Contract unchanged. Before → after, identical on 4.5.11, 5.1.2 and 5.2.1: default 0 → 0,
--no-sdf3 → 3.Framing: this example's render path has no
check_framingcall, against CLAUDE.md. Adding one would put exit 10 into a Track B example's table, so it is not added here. Framing was measured externally (.scratchprobe: the example's ownmain()with--output, thengallery_framing.check_framingon the resulting scene): fill x 0.828, min margin 0.075, code 0. The missing gate is recorded for a follow-up. Contact sheet:docs/gallery/contact-sheets/gn-sdf-remesh-contact-sheet.webp, luma 0.210.C —
examples/eval-mesh-datablock-nameREADME improvements:
evaluated_get().data.nameequals the source name on all three binaries, 4.5.11 included. The name test was never reliable; 5.2 removed its last working case.ID.is_evaluatedreadFalseon the evaluated mesh andID.originaldid not compare equal to the source, on all three. Neither is offered as a replacement.--assume-distinct-namesexiting 0 on 4.5.11 and 5.1.2 is correct by design.Re-verification (live probe):
evaluated_get().data.name, SUBSURFMeshMeshSourceMeshSourceMeshSourceMeshSourceMeshto_mesh().nameSourceMeshSourceMeshSourceMesh--assume-distinct-namesexitDocumented behaviour is correct. No code change.
Also
showcase/README.mdconventions:--open-endsis the falsifier.docs/gallery/index.htmlcarries both card alts in the sdf-remesh commit, because one build regenerates both.🤖 Generated with Claude Code