fix: iron-cauldron, campfire, usd-export-evaluation-mode and gn-modifier-inputs quality pass - #234
Merged
Conversation
…its ears The pot was a quadratic from a 28 mm tip; it is now a superellipse belly on a flat base (pot form, exit 19, --pointed-pot). The ear rings stood in the bail's plane so the bail ran through their tubes; they lie flat now and the bail threads them, ends hooking outward (exit 17, --edge-on-ears). Cast iron, per-pole wood, temp glb removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Each ring stone is a lofted chamfered lump with a seeded belly, offset and crown; beds stay flat so the courses still seat. Stone variation budget (exit 20, --uniform-stones). Fieldstone, wood and ember materials; temp glb removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Render path only: both subdivided balls hovered 0.16 m above the floor; each now rests on z = 0 from its evaluated vertices. Brighter key. Contract and exit codes unchanged on 4.5.11, 5.1.2 and 5.2.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Layout and render only: XS overlapped the 2 m and 3 m cubes by 0.2 m; they now stand 0.5 m apart. Frontal camera, duller finish. The check reads only Z extents; contract and exit codes unchanged on 4.5.11, 5.1.2 and 5.2.1. Also regenerates the gallery index for all four items. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
… stones From the iron-cauldron and campfire passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass: four items, two showcase (Track A) and two gallery examples (Track B). Every pathology/cross-version example (Track C) had already been reviewed. Everything below comes from live runs on
.scratch/blender-{4.5.11,5.1.2,5.2.1}-windows-x64/blender.exe, which report 4.5.11 LTS / 5.1.2 / 5.2.1 LTS, unless it is labelled inspection. Baselines were taken on the pristine tree before any edit.(The prompt asks for "four or five pieces" in its intro and "two or three items" in Step 2. This run takes four.)
A —
showcase/iron-cauldronTook 3 inspection rounds.
Defects
pot_bottomclose-up). The profile was a quadratic from a 28 mm tip.hook_bailclose-up, top ortho).hook_bailandinteriorclose-ups)..glbexport leaked.Round 1 fixed 1 but overshot: the bellied pot read as a straight-sided pail, because the belly was only 24 mm wider than the mouth. Round 2 narrowed the mouth. Round 3 fixed 2 and 3.
Fixes, and why each is structural
pot_profileis a superellipse belly from a stated 75 mm flat base (R_BOT) out toR_BELLY0.180 m atBELLY_Z(0.42 of the height), then a rounded shoulder in to a 0.128 m mouth (R_TOP, was 0.148). The inner wall is offset along the profile's normal; a sideways offset would thin the wall to nothing where it runs flat under the belly.R_TOP + RIM_OUT + EAR_MAJOR + EAR_MINOR − EAR_BITE), so each bites 2 mm into the rim's outer edge, and the bail, vertical where it passes, threads them. Past each ear the bail curve is mirrored about the ring, so the ends hook outward.cauldron_materials: near-black rough cast iron with rust in the pores, plus per-polePlankTone/GrainDirwood (fromshipping-crate).New budgets, identical on 4.5.11, 5.1.2 and 5.2.1:
Triangles: 3664 → 3664 (same topology, new shape). Pot–leg clearance 0.0464 → 0.0528. Collider 250 → 246. Same-binary deterministic.
Falsifiers, all on all three binaries:
--pointed-potrestores the quadratic profile → 19 (base 0.028, widest at 0.727).--edge-on-earsrestores the old rings → 17 (36 ring vertices inside the bail). The envelope is unchanged (the tripod sets it).Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--lift-z16→16,--stray-vert15→15,--short-legs16→16,--float-hook17→17,--pipe-ferrule18→18.Hero:
check_framingwithoutdeviation=. Contact sheet:docs/gallery/contact-sheets/iron-cauldron-contact-sheet.webp, luma 0.177 (band 0.151–0.305), stage 0.172.A —
showcase/campfireTook 1 inspection round plus a jitter adjustment checked in the hero.
Defects
ring_topandring_jointclose-ups)..glbexport leaked.Fixes, and why each is structural
add_stonelofts a chamfered octagon section along each stone's span. The section swells to a seeded belly mid-stone, pinches toEND_PINCHand is capped at the ends, and has a seeded radial offset and outer-face wobble. Top-course stones get a seeded crown. Beds stay flat, and the bottom course's crown stays at bed height, so the course seat is unchanged (0.00000).stations = 3 + bevel_segmentskeeps the high/low bake pair distinct. The oldadd_wedgeand stone bevel pass are removed.campfire_materials: fieldstone fromstone-archway's recipe (isotropic mottling, speckle, pitting, per-stonePieceTone); wood with per-piece tone and grain along each stick; ash with sparse ember emission.STONE_JITTER0.10 → 0.22.New budget, identical on all three binaries:
Triangles: 2200 → 2760 (ceiling 3600). Collider 198 → 162. The stated ring height
RING_H0.156 → 0.176 m for the crowns (measured 0.1759).OUTER_SIZEunchanged; measured (0.8024, 0.8022, 0.4037). Same-binary deterministic.Falsifier:
--uniform-stonesgives every stone the same draw → 20 on all three binaries (spread 0.00000). The first version zeroed every jitter and exited 8, because the ring shrank 15 mm. Following "keep a falsifier's envelope still", every jitter now sits at its upper bound instead: the stones are identical, and the envelope (0.8147) stays within tolerance.Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--short-stones16→16,--float-logs17→17,--gap-courses18→18.Hero: framing passes without
deviation=. Contact sheet:docs/gallery/contact-sheets/campfire-contact-sheet.webp, luma 0.217, stage 0.178.B —
examples/usd-export-evaluation-modePresentation changes (render path only):
bound_boxand did not move them; the probe caught it.Contract unchanged. Before → after, identical on all three binaries: default 0 → 0,
--evaluation-mode VIEWPORT4 → 4,--subdivision BEST_MATCH4 → 4.Framing:
check_framingin the render path passes (fill x 0.803, min margin 0.053). Contact sheet:docs/gallery/contact-sheets/usd-export-evaluation-mode-contact-sheet.webp, luma 0.188.B —
examples/gn-modifier-inputsPresentation changes (layout and render only):
XSwas (−2.2, 0.15, 2.45), which overlapped the 2 m and 3 m cubes by 0.2 m, although the comment above it promised a clear gap. Now (−2.6, −0.6, 2.4), 0.5 m apart. The check reads only each cube's evaluated Z extent and zmin, never X.Contract unchanged. Before → after, identical on all three binaries: default 0 → 0,
--same-scale7 → 7.Framing:
check_framingpasses (fill x 0.778, min margin 0.069). Contact sheet:docs/gallery/contact-sheets/gn-modifier-inputs-contact-sheet.webp, luma 0.219.Also
showcase/README.mdconventions: A ring is threaded across its hole, never in its plane; A vessel has a base and a belly; Stones are lumps, and no two match.teaches/witnessesFixtext and root README alts and lines updated. Gallery regenerated, with the generated<img alt>and witness callouts read back.🤖 Generated with Claude Code