fix: hitching-post, hand-pump, shader-node-group and driver-wave quality pass - #236
Merged
Merged
Conversation
The bands were sized inside the post and only the chamfered corners showed, as black slits; they now wrap it 6.5 mm proud (band seat, exit 18, --sunk-bands). Per-piece wood, rusted iron, 60 m stage, sorted bevel input, temp glb removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
No geometric defect found. The iron read as chrome (metallic 1.0, roughness 0.38); it is now painted cast iron with dark rust. Per-piece wood, 60 m stage, sorted bevel input, temp glb removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Render path only: Standard view transform, dark stage, softer key, camera aimed at the spheres. Contract and exit codes unchanged on 4.5.11, 5.1.2 and 5.2.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Render path only: the camera looks down 18 degrees so the column tops and shadows read as a wave. Contract and exit codes unchanged on 4.5.11, 5.1.2 and 5.2.1. Also regenerates the gallery index for all four items. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
From the hitching-post and hand-pump passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass: four items, two showcase (Track A) and two gallery examples (Track B). Every pathology/cross-version example (Track C) had already been reviewed. Everything below comes from live runs on
.scratch/blender-{4.5.11,5.1.2,5.2.1}-windows-x64/blender.exe, which report 4.5.11 LTS / 5.1.2 / 5.2.1 LTS, unless it is labelled inspection. Baselines were taken on the pristine tree before any edit.(The prompt asks for "four or five pieces" in its intro and "two or three items" in Step 2. This run takes four.)
A —
showcase/hitching-postTook 1 inspection round.
Defects
midandfootclose-ups, three-quarters). The two iron bands were sized fromhalf - grip: an inner half-width of 53 mm and an outer of 61 mm, against a 62.5 mm post face. They sat inside the post, and only the chamfered corners broke the surface..glbexport leaked. The bevel input was a Python set of edges (the face-order hazard found in fix: wooden-ladder, wheelbarrow, curve-bevel-arc and sky-texture-sun-elevation quality pass #235).Fixes, and why each is structural
BAND_BITE1.5 mm in, and the band standsBAND_T − BAND_BITEproud. The shoe collar is unchanged.PlankTone/GrainDirwood (post, rail, cap) and rusted iron. 3: stage 60 m. 4: export removed after measuring; bevel input sorted by edge index.New budget, identical on 4.5.11, 5.1.2 and 5.2.1:
The existing
band_gapcheck could not catch the defect: a sunk band overlaps the wood, and overlap passes.Triangles: 1680 → 1680. Same-binary deterministic (three runs).
Falsifier:
--sunk-bandsrestores the old bands → 18 on all three binaries (proud −0.0015 m).Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--short-post19→19,--twin-sole15→15,--clip-ring18→18.Hero:
check_framingwithoutdeviation=. Contact sheet:docs/gallery/contact-sheets/hitching-post-contact-sheet.webp, luma 0.179 (band 0.151–0.305), stage 0.179.A —
showcase/hand-pumpTook 1 inspection round. No geometric defect found. Every joint in the sheet (spout root, flange bolts, head and handle pivot, column step, plinth) seats as its budget says. The defects were surface:
.glbleak; set-ordered bevel input.Fixes: near-black painted cast iron (metallic 0.55, roughness 0.52) with dark rust in the pores; per-piece wood; stage 60 m; export removed; bevel input sorted. With no new geometric defect there is no new budget, and I did not invent one.
Triangles: 1064 → 1064. Same-binary deterministic (three runs).
Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--float-flange18→18,--float-spout17→17,--skinny-col19→19.Hero: framing passes without
deviation=. Contact sheet:docs/gallery/contact-sheets/hand-pump-contact-sheet.webp, luma 0.160.B —
examples/shader-node-groupPresentation changes (render path only): the Standard view transform (none was set, so AgX washed both tints toward pastel); the house dark stage (the floor was 0.055 and the world 0.008); a larger, softer key (the glossy spheres had mirrored a hard white square); a 50 mm lens and a Track-To aim at the sphere centres. README: staging note.
Contract unchanged. Before → after, identical on all three binaries: default 0 → 0,
--same-tint6 → 6.Framing:
check_framingpasses (fill x 0.762, margins 0.119 / 0.217). Contact sheet:docs/gallery/contact-sheets/shader-node-group-contact-sheet.webp, luma 0.284, stage 0.255.B —
examples/driver-wavePresentation changes (render path only): the camera is raised to look down about 18° (from 86° pitch, nearly level), so the column tops and their shadows read as a wave instead of a flat bar chart. README: staging note.
Contract unchanged. Before → after, identical on all three binaries: default 0 → 0,
--flat-expr3 → 3.Framing:
check_framingpasses (fill x 0.884, min margin 0.056). Contact sheet:docs/gallery/contact-sheets/driver-wave-contact-sheet.webp, luma 0.192.Also
showcase/README.mdconventions: A band wraps its host; it is never sunk into it; Iron is not chrome; The stage is bigger than the frame.witnessesFixtext and root README alts updated. Gallery regenerated, with the generated<img alt>read back.🤖 Generated with Claude Code