fix: anvil, signpost, text-version-stamp and cross-version-property-delete quality pass - #237
Merged
Merged
Conversation
The waist was lofted from ellipses and read as a funnel; it is now a squared superellipse section flaring foot to pinch to body (waist form, exit 19, --round-waist). Dark forged steel, per-piece wood, 60 m stage, temp glb removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
No geometric defect found. Boards are cream paint worn through to the wood, the iron is rusted instead of chrome, per-piece wood, 60 m stage, sorted bevel input, temp glb removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Render path only: the numerals stand on a plinth with the caption set into its face; the floating caption and edge glow bar are gone. Standard view. Contract and exit codes unchanged on 4.5.11, 5.1.2 and 5.2.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
…tand Render path only: the tags hang from the bar on rods instead of floating in front of it. Contract and exit codes unchanged on 4.5.11, 5.1.2 and 5.2.1. Also regenerates the gallery index for all four items. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
From the anvil and signpost passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass: four items, two showcase (Track A) and two gallery examples (Track B). Every pathology/cross-version example (Track C) had already been reviewed. Everything below comes from live runs on
.scratch/blender-{4.5.11,5.1.2,5.2.1}-windows-x64/blender.exe, which report 4.5.11 LTS / 5.1.2 / 5.2.1 LTS, unless it is labelled inspection. Baselines were taken on the pristine tree before any edit.(The prompt asks for "four or five pieces" in its intro and "two or three items" in Step 2. This run takes four.)
A pick I dropped:
swatch-gridwas picked for Track B, then left alone. Its contract samples the rendered PNG (verify_png()reads fixed grid-cell positions under a fixed ortho camera), and the flat emissive orange swatch is part of what it witnesses. Any change to layout or camera would touch an assertion.uv-layer-grid(verify_stillsamples pixel patches) is locked the same way.cross-version-property-deletetook the slot.A —
showcase/anvilTook 1 inspection round.
Defects
anvil_seatclose-up, hero)..glbexport leaked.Fixes, and why each is structural
WAIST_P4.5) lofted through five stations that flare from the foot in to a pinch and out to the body. The section is squared; the ellipse was the parameter at fault.New budget, identical on 4.5.11, 5.1.2 and 5.2.1:
Triangles: 2988 → 3052 (two more waist stations; ceiling 4500). Same-binary deterministic (three runs). The stave bevel input is built from an ordered vertex list, so it was already deterministic.
Falsifier:
--round-waistsets the section exponent to 2 → 19 on all three binaries (0.7071).Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--short-staves16→16,--float-anvil17→17,--round-band18→18.Hero:
check_framingwithoutdeviation=. Contact sheet:docs/gallery/contact-sheets/anvil-contact-sheet.webp, luma 0.180 (band 0.151–0.305).A —
showcase/signpostTook 1 inspection round. No geometric defect found: boards, straps, bands and shoe seat as their budgets say. The defects were surface:
.glbleak; set-ordered bevel input.Fixes: cream paint worn through to the wood by a noise mask, a shade apart per board (
board_material); rusted iron; per-piece post wood; stage 60 m; export removed; bevel input sorted by edge index. No new budget.Triangles: 376 → 376. Same-binary deterministic (three runs).
Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--short-shoe16→16,--float-strap18→18,--gap-board17→17,--yaw-boards19→19.Hero: framing passes. Contact sheet:
docs/gallery/contact-sheets/signpost-contact-sheet.webp, luma 0.167.B —
examples/text-version-stampPresentation changes (render path only): the numerals stand on a dark plinth with the steel caption set into its front face. The caption used to float in the air above the stamp, and an emissive bar lay along the bottom edge of the frame. Also: Standard view transform, the house stage floor, and the camera reframed. README: staging note.
Contract unchanged. Before → after, identical on all three binaries: default 0 → 0,
--wrong-body4 → 4.Framing:
check_framingpasses (fill x 0.784, min margin 0.044). Contact sheet:docs/gallery/contact-sheets/text-version-stamp-contact-sheet.webp, luma 0.285.B —
examples/cross-version-property-deletePresentation changes (render path only): the two tags hang from the stand's bar on steel rods. The bar used to run 0.17 m behind the plates with nothing joining them, and the "rings" were solid discs (now hidden), so the plates hung on air. The bar now spans both plates, the post rises to it, and the base is as wide as what it carries. The camera was reframed. README: staging note.
Contract unchanged. The check reads ID properties, never geometry. The pristine script was run from a scratch copy for the baseline. Before → after, identical on all three binaries: default 0 → 0,
--skip-delete7 → 7,--unset-instead7 → 7.Framing:
check_framingpasses (fill y 0.733, min margin 0.072). Contact sheet:docs/gallery/contact-sheets/cross-version-property-delete-contact-sheet.webp, luma 0.207.Also
showcase/README.mdconventions: A forging is not a turning; Paint wears through to what is under it.witnessesFixtext and root README alts updated. Gallery regenerated, with the generated<img alt>read back.🤖 Generated with Claude Code