fix: wall-torch, tavern-stool and vertex-color-ao quality pass - #241
Merged
Merged
Conversation
…real torch The plate sat on the backing slab behind the stones with only its bolts showing, and the "torch" was a flame on a solid cup. The plate now seats on the stone face (exit 21), a level arm (exit 20) carries an open cup holding a leaning haft with a pitch wrap and upright flames, mortar and stones take separate tones, and the bake density is a budget (exit 22). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Every leg ended 3 mm above an open vertical ring on the floor. Each foot is now a sleeve on the leg's axis gripping it (exit 18, measured radially) over a level tread (exit 20), stretchers are staggered, members take their own wood tone, and a 1024 px bake with a texel budget (exit 21) removes the dark slivers the 256 px bake left on the legs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Render path only. The blue fill and rim lit the stage cold and the wedge grazed floor the camera barely saw; the rig is now near neutral with the wedge pooled behind the well. Bake, checks and exit codes unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
…ake texels Also refreshes the gallery cards and root README alts for the restaged stills and regenerates docs/gallery. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass: three items (two showcase pieces, one gallery example). Everything below comes from live runs on
.scratch/blender-{4.5.11,5.1.2,5.2.1}-windows-x64/blender.exe, which report 4.5.11 LTS / 5.1.2 / 5.2.1 LTS, unless it is labelled inspection. Baselines were taken on the pristine tree before any edit.Picks.
wall-torchandtavern-stool, two of the last four showcase pieces with only the old-era pass.vertex-color-ao, which the last run's report flagged as dark and muddy.swatch-gridwas the other candidate. Its flat orange sphere is its emission swatch, which is the contract, so it was left alone.A:
showcase/wall-torchTook 3 inspection rounds.
Defects
ortho_back, round 0 hero). It was seated on the backing slab, 4 mm behind the face of the stones laid over it, so only the four bolt heads showed. The plate-to-plaque gap budget passed because the plate still touched the slab.ortho_left,ortho_back,three_quarter_b, hero). It was a flame on a solid frustum cup, and the haft was a 26 mm stub hidden by the flame. It read as a brazier.ortho_left).three_quarter_b).three_quarter_b). The iron was metallic 0.88, roughness 0.38..glbleak. Stone bevel input unsorted.Fixes, and why each is structural
stone_face_y() − PLATE_BITE. It follows the stone depth if that changes.New budgets, identical on all three binaries:
The plate-to-stone gap (18) now measures to any stone shell, not only the slab. It reads 0.00057.
Triangles: 1528 → 2004 (band re-fitted from 1400–1700 to 1800–2250). Envelope 0.304 × 0.293 × 0.424 → 0.304 × 0.322 × 0.485 m. Collider 60 → 116. Hygiene all zero, z-fight 0. Same-binary deterministic: two full matrix runs printed identical default measurements.
Falsifiers, identical on all three binaries:
--droop-arm→ 20 (9.580°).--sink-plate→ 21 (proud −0.00400, seat 0.02000).--low-bake→ 22 (6.93 px).Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--float-arm17→17,--float-plate18→18,--skinny-plaque19→19.--float-platefirst landed on 17. It dragged the arm root off with the plate, and the shortened arm fell below the arm classifier. The arm root now stays at the seated plate.Hero:
check_framingwithoutdeviation=passes (fill y 0.733). Contact sheet:docs/gallery/contact-sheets/wall-torch-contact-sheet.webp. Luma 0.299 (band 0.151–0.305; the first relit hero measured 0.310 and the wedge was trimmed), stage 0.267, warmth +0.432, saturation 0.266.A:
showcase/tavern-stoolTook 1 inspection round on the geometry. A second fix came from the hero itself.
Defects
joint_foot0–3,ground_contact). Each leg ended 3 mm above a vertical, bottomless ring on the floor, with a 1 mm air gap around the foot, lopsided on the splayed legs. The old "ferrule bite" band of −0.005..0 m was measuring that gap.ortho_*)..glbleak.Fixes
1: Each foot is now a stack:
All of it is derived from the leg's own stations, per the "level sole on a raked leg" convention.
2: The front-back and side stretchers sit at
STRETCH_TandSTRETCH_T2.3: Per-member wood tone and grain; dark rusted iron.
4: A 1024 px bake with a 10 mm cage, locked in as a budget.
5: 60 m stage. Export deleted after it is measured.
New or changed budgets, identical on all three binaries:
Triangles: 2528 → 3040 (band re-fitted from 2300–3200 to 2750–3350). Collider 396 → 468. Hygiene all zero. Same-binary deterministic.
Falsifiers, identical on all three binaries:
--pipe-ferrule→ 18 (grip −0.00011).--sink-legs→ 20 (leg above tread −0.00887).--low-bake→ 21 (5.61 px).Existing exit codes, before → after, identical on all three: default 0→0,
--skip-decimate9→9,--stray-vert15→15,--lift-z16→16,--short-legs16→16,--float-stretchers17→17,--pipe-ferrule18→18.Hero: framing passes. Contact sheet:
docs/gallery/contact-sheets/tavern-stool-contact-sheet.webp. Luma 0.182, stage 0.190, warmth +0.050.B:
examples/vertex-color-aoInspection (hero, clay, wireframe, close-ups of the apron, windlass and bucket):
Presentation changes (render path only):
WEDGE_AT/WEDGE_POOL).Contract unchanged. The bake, the checks and the exit codes are untouched. Before → after, identical on all three binaries: default 0 → 0,
--falsify0 → 0.--falsifyrenders the inverted-bake variant and exits 0 by design. Framing and asset-quality gates pass on the new hero.Contact sheet:
docs/gallery/contact-sheets/vertex-color-ao-contact-sheet.webp.Also
showcase/README.mdgains three conventions:teaches,altandwitnessesFixtext and the root README alts are updated. The gallery is regenerated, and the generated<img alt>was read back. The build rejected the first torch alt at 204 characters; it now fits the 200 limit.tests/check_falsifier_targets.py: passed, 214 falsifiers across 28 pieces.🤖 Generated with Claude Code