fix: turntable and swatch-grid quality pass - #243
Merged
Merged
Conversation
Render path only, after the check. The 500-face head read as faceted plates and hovered just above the floor. It now carries a subdivision modifier, is seated 10 mm into the platter of a turntable plinth from its own lowest evaluated vertex, and the copper is less glossy. Rotation keys, sampled frames and exit codes are unchanged; framing measured out of band (fill y 0.789, margin 0.050) since the path has no framing call. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Render path only. The mirror gold reflected the near-black world and read as a black ball; a reflection-only sky (Light Path Is Glossy Ray) now gives it a warm overhead gradient while camera and diffuse rays still see the dark stage. The backdrop moves in behind the spheres so they cast contact shadows. Six-region pixel check and exit codes unchanged on all three binaries. Also refreshes the gallery alts and index for both examples. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass on two gallery examples, both Track B: the contract is frozen and only presentation changes. The binaries were
.scratch/blender-4.5.11-windows-x64(reportsBlender 4.5.11 LTS),blender-5.1.2-windows-x64(Blender 5.1.2) andblender-5.2.1-windows-x64(Blender 5.2.1 LTS). The heroes were rendered on 5.2.1 throughscripts/render_hero.py. The inspection sheets (clay three-quarter, wireframe, hero angle, close-ups) stayed in.scratch/.Picks: every showcase piece and every check-only example has already had a pass. So this run takes the examples the last report scored weakest.
turntableandswatch-gridneeded work.uv-layer-gridwas inspected and left alone: its flat left panel is the contract, and the render is already pixel-verified against it.turntable(Track B)Defects (round 0):
close_contact.shade_smooth. Seen inclose_faceand the hero.Presentation changed: a new
stage_turntable()runs insiderender_still, after the correctness check. It adds a subdivision modifier (levels 2), a plinth plus a brushed platter, and a rougher copper (0.38). The head is lifted so its lowest evaluated vertex seats 10 mm into the platter; that height is derived from the mesh, not a constant. The camera is pulled back.Contract unchanged:
build(),correctness(), the rotation keys, the sampled frames and the exit codes are untouched.--no-keys/--output--no-keys/--outputFraming: this render path does not call
gallery_framing.check_framing. Adding the call would add exit code 10, and Track B forbids changing exit codes, so it is not added here. I measured framing out of band with the helper on the final scene: fill y 0.789, margins ≥ 0.050,framing_ok. Wiring the gate in is a separate decision for a future PR.swatch-grid(Track B)Defects (round 0):
close_goldand the hero.close_side.The flat orange emissive disc is what emission looks like, so it was left alone.
Presentation changed: the world is a reflection-only sky. Light Path "Is Glossy Ray" mixes in a warm overhead gradient above a dark horizon, while camera and diffuse rays still see the 0.02 stage. The backdrop moves from y = 2.5 to 1.08, 0.16 m behind the spheres, so each casts a soft contact shadow. Four variants were prototyped first, each checked against
verify_png. A uniform glossy world made the gold flat tan and put fresnel halos on the plastics; the gradient at 0.70 did not.Contract unchanged: sphere positions, materials, the camera,
verify_png, and the exit codes are untouched. The pixel check still reads 6 distinct regions on every binary.--same-base/--output--same-base/--outputThe framing gate passes on the
--outputpath (exit 0 above).Contact sheets
Checks run locally:
check_exit_code_readme.pyandcheck_gallery_images.pypass. I read the generated alt text indocs/gallery/index.htmland in both detail pages.🤖 Generated with Claude Code