fix: bake-normal-high-to-low and lightmap-uv-channel quality pass - #244
Merged
Merged
Conversation
Render path only. Both panels balanced on an edge and the leaning plate pierced the floor; each now stands in a low plinth, lifted so its lowest evaluated point seats 35 mm in the slot. The solidify rim wears plain bronze rather than the baked map. Bake statistics (frac 0.7211, MAD 0.09356) and exit codes unchanged on all three binaries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
The four 1.35 m posts stopped 0.33 m under the canopy arc, so the canopy floated. Each post now rises into the arc's underside at its own station, its top sheared to the arc for a uniform 12 mm bite. Every part keeps its UV1 island count, zero overlap and minimum island distance; exit codes are unchanged on all three binaries. Also refreshes the gallery alts and index for both examples. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass on two gallery examples, both Track B: the contract is frozen, and only presentation and demo scaffolding change. The binaries were
.scratch/blender-4.5.11-windows-x64(reportsBlender 4.5.11 LTS),blender-5.1.2-windows-x64(Blender 5.1.2) andblender-5.2.1-windows-x64(Blender 5.2.1 LTS). The heroes were rendered on 5.2.1 throughscripts/render_hero.py. The inspection sheets (hero angle, clay three-quarter, wireframe, per-object close-ups, ground contact) come from each example's own render scene via its framing call and stayed in.scratch/.Picks: every showcase piece and every check-only example has already had a pass. So these are the lowest-scoring examples not yet reviewed:
bake-normal-high-to-low(weakest hero) andlightmap-uv-channel(flagged in the last report). I also looked atmodular-kit-snapandsocket-attach-points; both are strong and were left alone.bake-normal-high-to-low(Track B)Defects (round 0):
ground_contactand the hero.close_1_BakeLow_a.Presentation changed:
seat_on_plinth()stands each panel in a dark plinth sized from its own footprint. The panel is lifted so its lowest evaluated vertex sits 35 mm in the slot, a height read from the mesh, not a constant.material_offset_rim.elements.Left as-is, because it is the contract: the rippled bronze surface and the faint waviness along the plate's border are the baked map itself. The waviness is normal-map shading inside the UV margin, and the silhouette is straight in the clay pass.
Contract unchanged: the bake,
map_stats, and every gate and exit code are untouched. The measured stats are identical before and after on all three binaries: detail frac 0.7211, MAD 0.09356; flat control frac 0.0000, MAD 0.00277.--flat-source/--output--flat-source/--outputFraming: fill x 0.809, minimum margin 0.078, ok.
lightmap-uv-channel(Track B)Defects (round 0):
Scaffolding changed: each post now rises from inside the bed into the canopy's underside at its own y, computed from the canopy's radius, thickness and base height. Its top vertices are sheared to follow the arc, which gives a uniform 12 mm bite into the 40 mm canvas; a flat top under a sloped arc would be buried on one side and open on the other. The canopy constants are shared, so a dimension change keeps the posts seated.
Contract unchanged: the UV0/UV1 names, flags, overlap SAT, island margin and watertightness checks, and all exit codes are untouched. On 5.2.1 every one of the 21 parts, the four posts included, reports the same loops, triangles and island count, zero overlap and the same minimum island distance before and after: 21 parts, 3680 islands.
--falsify/--output--falsify/--output--falsify PATHexiting 0 is by design: it renders the overlapping-atlas visual variant rather than tripping a gate (see the example README). The framing and asset-quality gates pass on the render path.docs/gallery/asset-sheets/lightmap-uv-channel.webpis the before/after record from the #117 remodel. There is no committed tool to regenerate it, so it is left as historical evidence. Its "after" tile shows the short posts this PR fixes.Contact sheets
Checks run locally:
check_exit_code_readme.pyandcheck_gallery_images.pypass. I read the generated alt text indocs/gallery/index.htmland in both detail pages.🤖 Generated with Claude Code