fix: vse-cut-list quality pass - #245
Merged
Merged
Conversation
Render path only; the Bay scene is staging. The monitor neck butted its top face onto the bezel's bottom on one plane with half its depth behind, and the PROGRAM caption lay flat on the desk 6 mm up, unreadable from the camera. The neck now rises 0.10 m into the bezel, the base sits 5 mm into the desk, and the caption stands on the desk's front face. Sequencer frame, checks and exit codes unchanged on all three binaries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass on
vse-cut-list, a Track B example: the contract is frozen, and only the staging of the editing bay changes. The binaries were.scratch/blender-4.5.11-windows-x64(reportsBlender 4.5.11 LTS),blender-5.1.2-windows-x64(Blender 5.1.2) andblender-5.2.1-windows-x64(Blender 5.2.1 LTS). The hero was rendered on 5.2.1 throughscripts/render_hero.py. The inspection sheets (hero angle, clay three-quarter, wireframe, per-object close-ups, ground contact) come from the example's ownBayscene via its framing call and stayed in.scratch/.Picks: every showcase piece and every check-only example has already had a pass. I inspected three unreviewed gallery examples and only one had a defect worth fixing:
vse-cut-list: fixed below.png-exr-alpha: both displays stand on struts in a plinth, captions are legible, ground contact is sound. No change.socket-attach-points: a hovering drone with its skid clear of the floor, every part attached, framing ok. No change.vse-cut-list(Track B)Defects (round 0):
close_5_BayCaption.Presentation changed: the part heights are now derived from named constants in the order they stack. The base bites the desk top by 5 mm; the neck starts inside the base and ends 0.10 m inside the bezel; the neck's depth (0.07 m) sits within the bezel's depth, set 0.02 m back. The caption stands upright on the desk's front face, set 1 mm into it. It is the same text curve with the same body, so nothing the example asserts about text strips is involved.
Contract unchanged: the sequencer frame on the screen is still the genuine rendered output. Every check and exit code is untouched, and the check line printed before and after is identical.
--swap-inputs/--output--swap-inputs/--outputFraming on the render path: fill y 0.850, minimum margin 0.067, ok.
Contact sheet
vse-cut-list: luma 0.2215, stage 0.195, warmth +0.018, saturation 0.10. All are in family and essentially unchanged from the old hero (0.2214), since the edit is small and local. Legible at thumbnail size, and the caption now reads.
Checks run locally:
check_exit_code_readme.pyandcheck_gallery_images.pypass. I read the generated alt text indocs/gallery/index.htmlanddocs/gallery/vse-cut-list/index.html.🤖 Generated with Claude Code