fix(scripts): measure_hero_drift exit codes and input errors - #315
Merged
Merged
Conversation
…nown --only, empty run - a size mismatch between fresh render and committed hero is a failure (exit 3) - an unknown --only name or a run that measured nothing exits 2 with a message - a failing `blender --version` probe or unrunnable binary exits 2 instead of IndexError - a bare trailing --output in a README command is handled, not an IndexError - unit tests (no Blender) run in the validate-harness job Closes #296 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #296. Size mismatch now fails (exit 3); unknown
--only, nothing measured, and an unusable Blender binary exit 2 with a clear message; bare--outputhandled. Exit codes documented in the module docstring. Drift itself is still reported, not judged (unchanged).Proven by live run
tests/test_measure_hero_drift.py(7 tests, wired intovalidate-harness) passes; against the previous script 4 of them fail (size mismatch exits 0, unknown--onlyexits 0, nothing measured exits 0, version failure raises). Tests mock Blender and rendering.Established by inspection only
No real hero render was run; the changed paths are control flow around the render loop.
🤖 Generated with Claude Code