Skip to content

Fix transaction seconds and Android widget rendering - #384

Closed
quecai-niu wants to merge 1 commit into
TNT-Likely:mainfrom
quecai-niu:fix/transaction-time-widget-rendering
Closed

Fix transaction seconds and Android widget rendering#384
quecai-niu wants to merge 1 commit into
TNT-Likely:mainfrom
quecai-niu:fix/transaction-time-widget-rendering

Conversation

@quecai-niu

Copy link
Copy Markdown

Summary

  • Show transaction time down to seconds by default and preserve time when editing only the date.
  • Reduce Android widget bitmap size and downsample native decoding to avoid transparent widgets on MIUI.
  • Remove Android widget letterboxing by rendering the widget image full-height and fitting it to the host bounds.

Verification

  • Built dev debug APK successfully.
  • Installed and tested on Xiaomi 2211133C via USB.
  • Confirmed transaction list shows HH:mm:ss.
  • Confirmed MIUI desktop widget displays, updates, and no longer has transparent/white letterbox areas.

@TNT-Likely

Copy link
Copy Markdown
Owner

@quecai-niu 感谢贡献,还在小米真机上验证过 👍 两块改动本身方向都没问题。不过想请你先把这个 PR 拆分再继续——它现在把两个互不相关的改动和一大批格式化重排混在了一起,不好 review,将来某一块出问题也没法单独回滚。

里面其实是三类东西:

  1. 交易时间显示到秒(功能一):showTransactionTimeProvider 默认值改动、transaction_list_item.dartHH:mmHH:mm:ssamount_editor_sheet.dart 改日期时保留原时分秒。
  2. Android 小组件渲染修复(功能二,跟功能一完全独立):BeeCountWidgetProvider.kt 位图降采样、widget_manager.dart pixelRatio 4.0→1.5beecount_widget.xml fitXYhome_widget_view.dart 去掉 padding。
  3. 大量 dart format 重排:theme_providers.dart / amount_editor_sheet.dart / transaction_list_item.dart 里几十行 logger、参数换行,跟功能无关,却把真实改动淹没了(比如时间那行的实际改动埋在一堆换行里,很难一眼看出改了什么)。

建议:

  • 拆成 两个 PR,一个只做交易时间、一个只做小组件渲染;
  • dart format 的重排单独处理——要么在功能 PR 里 revert 掉无关行、只留功能改动,要么单开一个 style: PR。(如果是编辑器 format-on-save 顺手带出来的,这个 PR 里先撤掉这些无关行即可。)

这样每个 PR 聚焦一件事,好 review,也好独立回滚。拆好之后我再逐个过、合并。辛苦 🙏

@quecai-niu

Copy link
Copy Markdown
Author

感谢 review,我已经按建议拆分并去掉无关格式化重排:

两个新 PR 都基于最新 origin/main,并分别通过了:

  • flutter pub get
  • flutter build apk --debug --flavor dev -t lib/main.dart

这个混合 PR 我先关闭,后续在两个拆分 PR 里继续跟进。

@quecai-niu

Copy link
Copy Markdown
Author

已按维护者建议拆分为 #393#394,关闭这个混合 PR。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants