fix(docs): swap the navbar logo files so each one matches the mode it is used in - #2360
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dark mode the wordmark rendered dark ink on the dark navbar, so the header read as an icon and nothing else.
I got the mapping backwards in #2356.
docs.jsonpointedlogo.lightat the file with light ink, on the theory that Mintlify's field names were inverted. They are not.The markup is:
block dark:hiddenmeans shown by default and hidden in dark, which is light mode. Sologo.lightis the logo for light mode, exactly as the field docs say. I read the class as evidence of an inversion and wrote that into the PR body and the design spec. It was wrong.Rather than swap the keys in
docs.jsonand leavelogo.lightpointing at a file calleddark.png, the two files are swapped so the names match the mode they serve:logo/light.png#FFFFFF#1F1B16logo/dark.png#0E0D0D#F5F1EAdocs.jsonis unchanged. Only the two image files moved.https://claude.ai/code/session_01TvGVLvwiH8ahw2wghtVs8s