Repository navigation
feat(plugins): connect to Presto through the Trino plugin - #3712
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additionalDatabaseTypeIds), with its own icon, apresto://scheme andjdbc:presto://import.X-Presto-*headers and no client capabilities header, which Presto does not define.SELECT 1and reads its version fromsystem.runtime.nodes: it has noversion().information_schema.materialized_viewsand skips the table comment query: it has neithersystem.metadatatable.LIMITand no page navigation:OFFSETis off by default, and the grammar takes neitherFETCH NEXTnorLIMITbeforeOFFSET. A variant now keeps its curated pagination over its plugin's grammar, as it already does for case sensitivity.COMMENT ONedits, which its grammar lacks.KHyperLogLogandkllsketchread as binary./catalog/schemaon import and is written back that way on copy.PluginMetadataRegistry+TrinoDefaults.swift, next to Presto's.apple/scripts/probes/check-presto-protocol.shchecks each Presto fact above against a stock coordinator.PluginMetadataRegistryTypeCountTestsandSQLLexicalReadingsTestslist Presto,CellExpressionVocabularyTestsexpects noUPDATE ... DEFAULTon Presto,SQLDDLFallbackPolicyTestsclassifies Presto as an engine with SQL DDL,MacOnlyImportRowTestscovers Presto.Test plan
TableProTrinoCoreTests: Presto headers, no capabilities header, Presto response headers, introspection SQL, connect and version statements, structured values sent as text, sketch types.PluginMetadataRegistryVariantTests: Presto keepsLIMITpaging when the Trino plugin registers it, and a Presto browse writes noOFFSETorFETCH.PluginManagerVariantAccessorTests: a Trino plugin without Presto does not serve a Presto connection.ConnectionURLParserJDBCTestsandConnectionURLFormatterTests:presto://,jdbc:presto://and/catalog/schemapaths.prestodb/presto:latest(0.299): every check passes, including connect, catalogs, schemas, tables, aLIMITbrowse, the EXPLAIN variants and Cancel Query (DELETE onnextUrileaves the query FAILED).Fixes #3598