Repository navigation
Conversation
…t-import-roundtrip # Conflicts: # linux/crates/app/src/ui/workspace/import.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
round_trip_suite!intablepro-test-support, run by every driver (MySQL and MariaDB both, SQLite in the unit suite):NULL). Row count and every row's text compared.MAX_CSV_FILE_BYTESmoves from the app totablepro_core::importso the test reads the same limit.Z, or in another form SQLite reads, was refused by the import and by cell edits.4713-01-01 BC), from year 10000, or past chrono's last year were refused by the import and by cell edits. One past chrono binds as text cast to the column type.decimal(38,38)value failed to save or import (tiberius sends precision 39); it now goes as text. Decimal parameters are cast todecimal(38, s), so a multi-row import no longer narrows a full-precision value beside a shorter one.JSONExtract('<json>', '<type>').10000-01-01.linux/docs/testing.md(Export round trip), the PostgreSQL, SQL Server and ClickHouse driver pages,ROADMAP.md.Not in this PR
uri too longandToo many form fields. Sending parameters in the body is its own driver change.'', and formula-like text gets an apostrophe. Both by design; a lossless round trip needs Convert NULL to empty off and theNULLmarker.1,5with a clear error.Test plan
round_trip_suite!on PostgreSQL, MySQL, MariaDB, SQL Server, ClickHouse (--run-ignored only) and SQLite. Before the fixes the CSV case failed on SQLite, PostgreSQL and SQL Server, and the SQL case on ClickHouse; all pass now.csv_import::a_decimal_at_full_precision_keeps_every_digit_beside_shorter_ones,filter::a_decimal_filter_keeps_the_digits_it_was_given.parse_literal_text, PostgreSQL far-date binding, SQL Server decimal encoding and cast, ClickHouse JSON literals.meson testunder xvfb; rustfmt and both clippy runs.Fixes #3665