Repository navigation
feat(autocomplete): complete identifiers in the case the server folds them to - #3731
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 21, 2026 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
V$SESSIONwith the statement fromV$SQL, metrics fromV$SYSMETRIC(orV$CON_SYSMETRICin a pluggable database) andV$INSTANCE, slow queries as active calls over a second. Terminate isALTER SYSTEM KILL SESSION 'sid,serial#' IMMEDIATE; Cancel isALTER SYSTEM CANCEL SQLfrom 18c.currentOp(own operations only withoutinprog), metrics fromserverStatus, slow queries from the browsed database'ssystem.profile. Cancel iskillOp; there is no Terminate.DatabaseDriver.executeRead, which runs the script read-only, so a shell function an earlier statement redefined cannot write.CLIENT LISTminus the dashboard's ownCLIENT ID, metrics fromINFO, slow queries fromSLOWLOG GET 20. Terminate isCLIENT KILL ID; Cancel isCLIENT UNBLOCK … ERRORfor a blocked client.SLOWLOG GETreturns a grid (id, time, duration, quoted command, client, name).OUTSIDEBLOCK <command>runs a server command held back, not queued, while the user'sMULTIblock is open; every dashboard command uses it.slowlog|getjoins the curated cluster routing table so Redis 6 clusters fan it out too.OUTSIDEBLOCKthe way it reads pastDB <n>, soOUTSIDEBLOCK FLUSHALLstays destructive.get_server_dashboardandstop_server_sessionnow work on the three engines. A paired client withtools:readcan read their sessions, metrics and slow queries; withtools:writeand the user's approval it can cancel or kill a session there. The tool description no longer lists engines.DurationFormattinggains a sub-second form for slow log durations.ServerDashboardViewModelTests.redisHasNoDashboardis replaced (Redis now has a dashboard), andDashboardProviderSQLTests.callerExclusionsnames how the three new engines leave out their own session.Test plan
OracleDashboardProviderTests,MongoDBDashboardProviderTests,RedisDashboardProviderTests,RedisDashboardCommandTests(parser, slow log grid, held back inside a MULTI block), theOUTSIDEBLOCKclassifier case, theslowlog|getrouting case,RedisServerInfowhole-name reads.CANCEL SQL(ORA-01013 in the victim, session kept) andKILL SESSION(ORA-03113).helloleft out; profiler entries listed.CLIENT LIST,SLOWLOG GETshape,CLIENT UNBLOCKon aBLPOP, andapple/scripts/probes/check-redis-command-routing.shagainst the curated table.Fixes #3609