Repository navigation
fix(mysql): keep backup and restore from sending a plain-text password without TLS - #3742
Merged
Merged
Conversation
…nd MacPorts' plugin folder
…a handshake of its own
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mariadb-dumpandmariadbrun with a private plugin folder whenever the session might go without TLS: SSL Mode Disabled, or Preferred against a server that offers none. The folder links onlycaching_sha2_password,sha256_password,client_ed25519,parsec,auth_gssapi_clientandzstd, so a server asking formysql_clear_password,dialog(PAM) or Homebrew'sqa_auth_clientgets 2059 before anything is sent. The failure reads as in the app: set SSL Mode to Required, or turn TLS on.--ssl --skip-ssl-verify-server-certas before. None:--skip-ssland the folder, because--sslfalls back to plaintext and then answerscaching_sha2_passwordfull authentication with the typed password. A greeting that cannot be read stops the run.lib/pluginorlib/mysql/plugin(MariaDB's layouts, Homebrew) orplugin(MacPorts) beside itsbin.check-mysql-dump-plaintext-password.sh; the fake server inmariadb-tls-modestakes--auth cleartext|dialog|qa|sha2-fullin place of--cleartext;check-mysql-dump-tool-flags.shchecks--plugin-dir.Test plan
check-mysql-dump-plaintext-password.shwith mariadb-dump and mariadb 13.0.2 from Homebrew: 18/18 ok. The old Preferred options send the password to a server without TLS (last row of each tool); the new ones never do, and a native login still works.check-mariadb-tls-modes.shandcheck-mysql-dump-tool-flags.shpass.max_connect_errors=1and name resolution on: three greeting probes in a row, then a login, still succeed.MySQLDumpPlaintextPasswordTests,MySQLDumpPlaintextPasswordServiceTests,MySQLClientArgumentsTests,NativeDumpRegistryTests,NativeDumpService*Tests,ProcessNativeDumpRunnerTests,NativeDumpScopeTestspass.Follow-up to #3734. Docs: TableProApp/docs#95.