Repository navigation
perf(linux-sidebar): pick the sidebar's search rows off the GTK thread - #3747
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SidebarRows). The list takes them in one change and drops rows that a newer search or list overtook, as the completion'sProposalListdoes.SidebarReadare freed on the blocking pool: 6 to 17 ms of GTK thread for 50,000 tables in a debug build.SidebarView::newtakesOption<Tasks>. Without them, as in the unit tests, the rows are worked out on the GTK thread.Test plan
set_queryon the GTK thread went from 15 to 40 ms to under 0.1 ms. Search stall with 2,000 tables: 11 to 37 ms. With 50,000: 22 to 39 ms.large_catalog::mysql_database_of_50000_tables_lists_searches_and_completes, stall fori/in/"":a_list_and_its_searches_are_worked_out_off_the_gtk_threadandrows_worked_out_for_an_older_list_or_search_are_dropped.linux/changelog.d/3729.fixed.mdalready covers the sidebar freeze.Refs #3660