Repository navigation
feat(linux): connect to Redis, list its keys and run its commands - #3810
Merged
Merged
Conversation
# Conflicts: # linux/crates/app/src/ui/browse_tab/mod.rs # linux/crates/app/src/ui/grid/tab_grid_context.rs # linux/crates/app/src/ui/grid/test_grid.rs # linux/crates/app/src/ui/mod.rs # linux/po/POTFILES.in
…edis does, update license notices
…art a window whose key changed type
… a refresh, drop the empty username's @
…n the sink holds, prompt when no keyring runs
…ry once, keep table rows to one label
# Conflicts: # linux/ARCHITECTURE.md # linux/build-aux/debian/copyright # linux/crates/core/src/sql_syntax/catalog_change.rs # linux/data/licenses/third-party.json # linux/docs/decisions/README.md
…blanks through MCP
datlechin
enabled auto-merge (squash)
October 23, 2026 09:29
# Conflicts: # linux/crates/app/src/ui/editor/imp.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tablepro-driver-rediscrate on redis-rs 1.7 (aio,tokio-comp, no TLS features): every stream comes fromTransport::open, with TLS through tokio-rustls on aws-lc-rs, so direct and SSH-tunnelled connections work alike.linux/docs/decisions/0021-engines-without-sql.md, andlinux/docs/adding-drivers.md, Engines without SQL):DriverCapabilities::data_modelandusername_required,Connection::scan_keysandread_key,ReadOnlyEnforcement::ClientGuard,ServerCode::Redis, and aSqlGrammar::Rediswith its own rules insql_syntax/redis(one command per line read as redis-cli does, command access, history rules).SCANandTYPE, neverKEYS. The search goes to the server: plain text matches anywhere, text with*,?or[is a glob. A banner says when the list stops at 5,000 keys.MULTIis tracked as a transaction (Commit sendsEXEC, Roll BackDISCARD). Pub/sub,MONITORand other commands that stop one-reply-per-command are refused.CLIENT UNBLOCKfrom a link of its own, thenCLIENT KILL IDpast the grace.AUTH,HELLO ... AUTH,MIGRATE ... AUTH,ACL SETUSER,CONFIG SETof password parameters,SENTINEL SETand scripts that name them.@.ServiceUnknowncame back wrapped as a service error and read as a backend failure, instead of asking for the password.keyspace_conformance_suite!for key-value engines, a Redis fixture (plain, TLS-only, certificate-only), Redis 7.4 and 8.10 in CI, and a session test through OpenSSH.deny.tomlandabout.tomlforxxhash-rust, which redis-rs depends on; license notices regenerated.ctutilsto 0.4.4 for RUSTSEC-2026-0385, published today, which failed the supply chain check.docs/drivers/redis.md,adding-drivers.md,testing.md, README, ROADMAP, ARCHITECTURE, storage and error handling.Test plan
cargo nextest run -p tablepro-driver-redis --run-ignored onlyon Redis 8.10: the keyspace and TLS suites and the driver's own cases, 39 of 39.keys_list_and_commands_run_through_opensshintablepro-session, through a real OpenSSH tunnel.verify.shbuild, lint (both clippy runs) and l10n, the workspace unit suite, cargo deny, shear and the license notices.Screenshots
Fixes #3647