Repository navigation
fix(inspector): field resize handle tracks the drag and keeps a height per column - #3975
Merged
datlechin merged 4 commits intoNov 1, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…and harden the resize handle
datlechin
enabled auto-merge (squash)
November 1, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: TableProApp/docs#152.
Summary
FieldResizeHandleView), so the inspector'sListno longer takes the mouse a few points into a drag.NSCursor.dividerResize, shared withResizeCursorSplitViewController).InspectorFieldHeightStore, device-local, last 200 columns. It holds across rows, results and relaunches.MultiRowEditState.expandedColumn, keyed by column index. It survives a new selection and a deselect, and clears when the columns change.//notes.AppSettingsStorageMigrationTests,AppSettingsStorageResetTestsandPreferenceKeysGuardTestsnow pin the per-column key and the removal of the per-kind keys.Test plan
FieldResizeHandleTests: inside aList, a press on the grip lands on the handle view. Also drag deltas, click without drag, stray events, disabled handle, disable and removal mid-drag.InspectorFieldHeightStoreTests: per-column heights, relaunch, replacement, eviction past capacity, unreadable data, reload after reset.MultiRowEditStateExpansionTests: expansion survives a new row and a deselect, clears on new columns and on release.ResizableFieldMetricsTests: a base outside the range moves with the first point of drag; a zero drag commits nothing.