fix: add SQLite schema versioning for future migrations#594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
PRAGMA user_version-based schema migration infrastructure to both SQLite databases (query_history.dbandsql_favorites.db).Both databases currently use
CREATE TABLE IF NOT EXISTSwith no version tracking. If a future release needs to add a column, existing users would silently keep the old schema. This PR sets the foundation so future schema changes can useALTER TABLE ... ADD COLUMNmigrations gated by version checks.Changes:
QueryHistoryStorage.swift— AddedmigrateIfNeeded(),getUserVersion(),setUserVersion(). Current schema set to version 1.SQLFavoriteStorage.swift— Same three methods added. Current schema set to version 1.No schema changes are made — this just stamps the current schema as version 1 so future migrations have a baseline.
Addresses audit item C5.
Test plan
sqlite3 ~/Library/Application\ Support/TablePro/query_history.db "PRAGMA user_version;"returns1sqlite3 ~/Library/Application\ Support/TablePro/sql_favorites.db "PRAGMA user_version;"returns1