refactor(datagrid): consolidate sort click cycle into header view#944

Merged

datlechin merged 44 commits intomainfrom

refactor/datagrid-sort-click-cycle

Apr 29, 2026

Commits on Apr 29, 2026

refactor(datagrid): native sort indicators, FK button reuse fix, drop binding-mutation Task pattern
datlechin
committed
refactor(datagrid): name-based column identifiers, protocol-based layout persister
datlechin
committed
refactor(datagrid): address review — split persister protocol, drop redundant calls, add coordinator + schema-shift tests
datlechin
committed
fix(datagrid): compare column sets not arrays so user reorder does not trigger rebuild path
datlechin
committed
diag(datagrid): trace sort dispatch + SF Symbol fallback for sort indicator images
datlechin
committed
fix(datagrid): read live shift modifier from NSEvent for multi-sort detection
datlechin
committed
diag(datagrid): expand sort logging — modifier flags raw, indicator placement, syncSortDescriptors state
datlechin
committed
fix(datagrid): intercept shift+click in custom NSTableHeaderView for multi-sort
datlechin
committed
fix(datagrid): set all sort descriptors so multi-sort indicators render on every sorted column
datlechin
committed
fix(datagrid): custom NSTableHeaderCell renders indicators on every multi-sort column
datlechin
committed
fix(datagrid): use native NSAscendingSortIndicator at natural size, drop SF Symbol fallback and highlightedTableColumn duplication
datlechin
committed
fix(datagrid): clear AppKit's auto sort indicator so custom cell does not double-draw on primary
datlechin
committed
fix(datagrid): override drawSortIndicator to no-op so AppKit stops drawing duplicate chevron over custom cell
datlechin
committed
fix(datagrid): tint native sort indicator template image with secondaryLabelColor to match AppKit's subtle gray
datlechin
committed
fix(datagrid): tint sort indicator template image in offscreen context so fill respects only image alpha
datlechin
committed
fix(datagrid): tint sort indicator with tertiaryLabelColor for native subtle gray match
datlechin
committed
fix(datagrid): use SF Symbol chevron with light weight for sort indicator to match modern AppKit native style
datlechin
committed
fix(datagrid): tweak sort indicator alpha to 0.4 between secondary and tertiary label color
datlechin
committed
refactor(datagrid): use AppKit's native NSTableHeaderCell.drawSortIndicator for pixel-perfect chevron rendering on every sorted column
datlechin
committed
fix(datagrid): SF Symbol chevron with paletteColors config for native tinting
datlechin
committed
fix(datagrid): reduce sort indicator pointSize to 9 for smaller chevron
datlechin
committed
feat(datagrid): 3-state sort cycle + 'Don't Sort' context menu — native HIG-correct unsort UX
datlechin
committed
refactor(datagrid): split sort handling — AppKit drives single-click 3-state, SortableHeaderView only intercepts shift-click for multi-sort
datlechin
committed
i18n: add 'Don't Sort' string to Localizable catalog
datlechin
committed
fix(datagrid): override init(coder:) + copy(with:) on MultiSortHeaderCell to fix ARC crash on sort
datlechin
committed
fix(datagrid): drop SF Symbol paletteColors config, tint at draw-time in offscreen context to avoid ARC crash on sort
datlechin
committed
fix(datagrid): rip out MultiSortHeaderCell, use pure native NSTableView setIndicatorImage API to fix crash
datlechin
committed
refactor(datagrid): NSImageView overlays on header for multi-sort indicators — pure native, no NSCell subclass
datlechin
committed
fix(datagrid): clear highlightedTableColumn so AppKit does not auto-draw duplicate chevron + bold title on primary
datlechin
committed
fix(datagrid): explicit setIndicatorImage nil to clear AppKit auto-indicator on primary sort column
datlechin
committed
fix(datagrid): stateless NSTableHeaderCell subclass overrides drawSortIndicator to no-op — kills AppKit auto-indicator at source, no Swift property = no ARC crash
datlechin
committed
Merge branch 'main' into refactor/datagrid-column-architecture
datlechin
committed
refactor(datagrid): inject ColumnLayoutPersisting per view, drop shared singleton
datlechin
committed
fix(datagrid): preserve native sort cycle on column header clicks
datlechin
committed
fix(a11y): announce sort direction on data grid column headers
datlechin
committed
refactor(datagrid): drop redundant doc comment on visibility helper
datlechin
committed
test(datagrid): cover sort transitions, persister corruption, and literal col_0 identifier
datlechin
committed
docs: correct sort indicator implementation note in CHANGELOG
datlechin
committed
fix(datagrid): restore three-state sort cycle (asc, desc, none)
datlechin
committed
refactor(datagrid): consolidate sort click cycle into header view
datlechin
committed
Merge remote-tracking branch 'origin/main' into refactor/datagrid-sort-click-cycle
datlechin
committed
fix(datagrid): cycle multi-sort columns through ascending, descending, removed
datlechin
committed
fix(datagrid): apply optimistic sort state update on click to avoid stale-read races
datlechin
committed
fix(datagrid): preserve column reorder drag by deferring sort dispatch to mouse up
datlechin
committed