fix(datagrid): restore sort chevron via SF Symbols#947
Closed
fix(datagrid): restore sort chevron via SF Symbols#947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for a regression introduced by #945. Sort chevrons stopped rendering after switching from
NSImageViewoverlays to direct cell drawing.The private AppKit images
NSAscendingSortIndicator/NSDescendingSortIndicatoronly render viaNSImageView(withcontentTintColor) or AppKit's internalNSTableHeaderCell.drawSortIndicator. They do not produce pixels when drawn via rawNSImage.draw(in:from:operation:...)in a cell's graphics context. PR #945'sdrawInteriorreserved layout space for the indicator (which is why column titles got truncated when sorted) but the chevron itself never appeared.PR #942's commit history shows the previous author hit this exact issue and worked around it with overlays. #945 unknowingly reintroduced the regression.
Fix
Replace the private images with SF Symbols (
chevron.up/chevron.down) configured with palette tint.secondaryLabelColor. SF Symbols draw reliably viaimage.draw(in:)and the palette config handles tinting in both Light and Dark modes.One file changed, 5 insertions / 6 deletions.
Test plan
secondaryLabelColorcorrectly in both