fix(datagrid): render sort chevron via SF Symbol with palette tint#948
Merged
fix(datagrid): render sort chevron via SF Symbol with palette tint#948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Dark mode regression introduced by #945. The sort chevron was invisible in Dark mode (visible in Light mode).
Root cause
SortableHeaderCell.drawInteriorused the private AppKit SPI imagesNSAscendingSortIndicator/NSDescendingSortIndicator. These are template images. The helper functiondrawTintedIndicatorwas misleadingly named — it didn't actually tint anything, it just calledimage.draw(in:...). Template images then rendered in the default graphics-context fill color, which is BLACK.Fix
Switch to SF Symbols (
chevron.up/chevron.down) configured withSymbolConfiguration.paletteColors([.secondaryLabelColor]). SF Symbol palette tinting is appearance-aware, so Light/Dark mode rendering just works.Renamed the helper from
drawTintedIndicatortodrawIndicatorsince it no longer does any tinting (the symbol is pre-tinted via configuration). Function name now matches what it does.Why this is the cleanest approach
SymbolConfiguration.paletteColorstints at the symbol-rendering layer, respecting currentNSAppearanceautomaticallyNSGraphicsContextsave/restore +.sourceInblending hacksTest plan