Skip to content

refactor(datagrid): cleanup#954

Merged
datlechin merged 8 commits intomainfrom
refactor/datagrid-phase4-cleanup
Apr 30, 2026
Merged

refactor(datagrid): cleanup#954
datlechin merged 8 commits intomainfrom
refactor/datagrid-phase4-cleanup

Conversation

@datlechin
Copy link
Copy Markdown
Member

Summary

DataGrid Phase 4 — full cleanup refactor addressing 8 verified audit items in 1 atomic PR.

Real bugs (5)

Quality (3)

  • Add multi-line text editor for long text fields #22 — Removed pendingDropdown* instance vars from coordinator. Use NSMenuItem.representedObject carrying DropdownMenuContext reference type instead.
  • Add Intel Mac support with separate build strategy #18 — Routed remaining inline column - 1 / column >= 1 boundary checks through centralized helpers firstDataTableColumnIndex + isDataTableColumn(_:). Migrated KeyHandlingTableView + DataGridView+Editing.
  • [ImgBot] Optimize images #53 — Consolidated mixed displayCache.removeAll() + rebuildVisualStateCache() callsites into single invalidateAllDisplayCaches() method. Format-only and teardown invalidations kept narrower (different scope).

Files

8 files modified, +121 / -67:

  • TablePro/Core/ChangeTracking/PendingChanges.swift
  • TablePro/Views/Results/DataGridCellFactory.swift
  • TablePro/Views/Results/DataGridColumnPool.swift
  • TablePro/Views/Results/DataGridCoordinator.swift
  • TablePro/Views/Results/DataGridView.swift
  • TablePro/Views/Results/Extensions/DataGridView+Editing.swift
  • TablePro/Views/Results/Extensions/DataGridView+Popovers.swift
  • TablePro/Views/Results/KeyHandlingTableView.swift

Test plan

  • xcodebuild build (compile check)
  • swiftlint lint --strict
  • Manual: open table, verify header rendering unchanged
  • Manual: dropdown cell click → popover opens with correct row/col context
  • Manual: column reorder by drag persists correctly
  • Manual: cell with line breaks renders single-line correctly
  • Manual: theme switch updates fonts without crash
  • Manual: undo cell edit / row delete works (changeIndex correctness)
  • Manual: keyboard arrow nav across columns (boundary helpers)

@datlechin datlechin changed the title refactor(datagrid): Phase 4 cleanup refactor(datagrid): cleanup Apr 30, 2026
@datlechin datlechin merged commit 8569671 into main Apr 30, 2026
2 checks passed
@datlechin datlechin deleted the refactor/datagrid-phase4-cleanup branch April 30, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant