Merged
Conversation
…or on theme observer
…order immediately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataGrid Phase 4 — full cleanup refactor addressing 8 verified audit items in 1 atomic PR.
Real bugs (5)
headerFontwas a computed property recreating NSFont on every call. Nowprivate static let.@MainActor. Added annotation.sanitizedForCellDisplaydid double scan (containsLineBreak then replacement). Now true single-pass.firstIndex(where:)per slot). Built[NSUserInterfaceItemIdentifier: Int]index map, O(1) lookup.removeChangeAtO(N) per removal (loop updating changeIndex dict). Replaced with swap-and-pop, O(1).Quality (3)
pendingDropdown*instance vars from coordinator. UseNSMenuItem.representedObjectcarryingDropdownMenuContextreference type instead.column - 1/column >= 1boundary checks through centralized helpersfirstDataTableColumnIndex+isDataTableColumn(_:). Migrated KeyHandlingTableView + DataGridView+Editing.displayCache.removeAll()+rebuildVisualStateCache()callsites into singleinvalidateAllDisplayCaches()method. Format-only and teardown invalidations kept narrower (different scope).Files
8 files modified, +121 / -67:
Test plan