Repository navigation
Add a share modal, renew sharing links when opened, and improve modal accessibility - #12
Merged
Merged
Conversation
|
@wajrock is attempting to deploy a commit to the Tabularis Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking Share now opens a modal that explains how sharing works before anything leaves the browser. Sharing links are renewed when they are opened, and the promo modal is now usable with the keyboard.
What changed
Share modal
Link renewal
Accessibility
Modalcomponent, used by both the share modal and the promo modal.Other
Tests
60 tests pass, with 91% line coverage. New tests cover the share modal (nothing sent before the click, link reused, error message), keyboard focus in the modals, and closing the video without closing the promo.