Skip to content

Add a share modal, renew sharing links when opened, and improve modal accessibility - #12

Merged
wajrock merged 3 commits into
TabularisDB:mainfrom
wajrock:fix/promo-focus-footer
Oct 8, 2026
Merged

wajrock merged 3 commits into
TabularisDB:mainfrom
wajrock:fix/promo-focus-footer

Conversation

@wajrock

@wajrock wajrock commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Clicking Share now opens a modal that explains how sharing works before anything leaves the browser. Sharing links are renewed when they are opened, and the promo modal is now usable with the keyboard.

What changed

Share modal

  • Share opens a modal that states three things: the plan is encrypted in the browser and the key exists only in the link, the link stays available for 30 days after it was last opened, and anyone with the link can open the plan.
  • Nothing is sent until the user clicks Copy link. The button then creates and copies the link, with a state for each step: Copy link, Creating link, Copied, and Try again if it fails.
  • Reopening the modal, or sharing from a page opened through a sharing link, copies the existing link without storing the plan again.

Link renewal

  • When a link is opened and its blob is more than a day old, the Worker rewrites it under the same id, which restarts the 30-day R2 lifecycle rule.
  • Links now expire 30 days after they were last opened instead of 30 days after they were created.
  • Renewal runs in the background, and the one-day threshold limits it to one R2 write per link per day, even if a link is reloaded in a loop.

Accessibility

  • The focus handling now lives in a shared Modal component, used by both the share modal and the promo modal.
  • Focus moves into the modal when it opens, Tab and Shift+Tab cycle through its controls, Escape closes it, and focus returns to where it was.
  • Closing the demo video with Escape no longer closes the promo modal behind it.

Other

  • The footer is separated from the PlanView with a larger gap.
  • The FAQ, the Highlights, the error screen and the README describe the renewal.

Tests

60 tests pass, with 91% line coverage. New tests cover the share modal (nothing sent before the click, link reused, error message), keyboard focus in the modals, and closing the video without closing the promo.

@vercel

vercel Bot commented Oct 8, 2026

Copy link
Copy Markdown

@wajrock is attempting to deploy a commit to the Tabularis Team on Vercel.

A member of the Team first needs to authorize it.

@wajrock
wajrock merged commit 847adbf into TabularisDB:main Oct 8, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant