docs: planning doc for data compare & diff tool - #527
Draft
aesslinger wants to merge 6 commits into
Draft
Conversation
Covers data comparison (row-level diffs) and schema comparison (DDL diffs) as a combined tool with mode toggle. Includes: - 5 SVG mockups (setup panel, results view, sync script, schema compare, schema migration script) - Architecture decision (new tab type + pop-out window) - Phased implementation plan (4 phases, ~11 weeks) - State model and component tree - Driver abstraction analysis (multi-database nuances) - Safety & permissions design (dry-run, transactions, rollback scripts) - Row ordering strategy (merge-join on sorted comparison key) - Composite key handling - Value serialization by dialect - Live vs snapshot query semantics - Connection error handling - Partial sync selection UX - Accessibility requirements (color + icon markers) - Comprehensive testing strategy - 10 open questions for discussion
Collaborator
|
Hi @aesslinger Here are my thoughts on the open questions:
This is my take, but it's not set in stone. I'm more than open to discussing any of these points. FYI @NewtTheWolf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planning document and mockups for a new Compare & Diff feature. Looking for design feedback before implementation begins.
Ref #21
What's in this PR
No code changes — just a comprehensive planning doc at
.github/planning/data-compare-feature.mdwith 5 SVG mockups.Feature Summary
A unified comparison tool with two modes:
Both modes share the same UI shell (source/target selectors, summary bar, sync script panel) with a Data/Schema mode toggle.
Key Design Decisions (seeking feedback)
"compare"tab type in the Editor (not a separate page), with pop-out window supportOpen Questions (10)
Listed at the bottom of the doc — would especially appreciate input on:
Mockups
5 SVG mockups in
.github/planning/mockups/: