fix(submit): gate submit on maintain+ permission, not namespace ownership - #1
Merged
Merged
Conversation
….13.0 Stale codeberg image.repository + appVersion 0.11.1 would clobber the live 0.13.0 deploy on any chart re-apply. Point the default at GHCR, bump chart version + appVersion to 0.13.0, and retarget sources/maintainer URLs to the GitHub org.
Handoff for the Tabularis client: JWKS + integrity endpoints, JWS/Ed25519 verification flow, per-asset SHA-256 checks via @tabularium/manifest, and the release-asset requirement for a signed install.
…ship checkOwnership previously required the repo to live in the user's personal namespace (owner.login === username), rejecting org/group repos even with full write access. Now accepts maintain+ (GitHub/Gitea admin||maintain, GitLab access_level>=40). list-repos filter aligned (push -> maintain). Gitea has no maintain field, so admin is its ceiling equivalent.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
checkOwnershiprequired the repo to live in the user's personal namespace (owner.login === username). Org/group repos were rejected even with full write/admin access, and the submit check was stricter than the repo-picker list (which allowedpush).Fix
providers.ts): acceptpermissions.admin || permissions.maintain. Gitea has nomaintainfield, so admin is its ceiling equivalent (noted inline).providers.ts): acceptaccess_level >= 40(Maintainer=40, Owner=50), max of project + inherited group access.admin || push→admin || maintain; GitLab list already usedmin_access_level=40.usernameparam fromcheckOwnership+ helpers; updated both callers (submit/oauth.ts,submit/preview.ts).tsc + biome clean.