Devicetree updates

[KenVanHoeylandt]

Summary by CodeRabbit

• New Features

  • Added I2S audio interface support to LilyGO TLora Pager, M5Stack Cardputer, M5Stack Cardputer Adv, M5Stack Core2, and M5Stack CoreS3 devices with configurable audio pins and port mappings.

• Chores

  • Improved device tree compiler grammar to separately handle line and block comments.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request modifies the device tree compiler grammar to separately handle single-line and multi-line comments, replacing a unified COMMENT token with SINGLE_LINE_COMMENT and MULTI_LINE_COMMENT tokens. Additionally, the PR adds I2S (Inter-IC Sound) audio interface nodes to device tree files for six hardware boards: lilygo-tdeck, lilygo-tlora-pager, m5stack-cardputer-adv, m5stack-cardputer, m5stack-core2, and m5stack-cores3. Each device tree file receives an i2s0 node with ESP32 I2S configuration including compatible strings, port numbers, and audio pin mappings. The lilygo-tdeck device tree undergoes a node repositioning of its existing i2s0 block.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title "Devicetree updates" is vague and generic, using non-descriptive language that fails to convey the specific nature of the changes.	Consider using a more specific title that highlights the main changes, such as "Add I2S interface configurations across multiple devicetree files" or "Refactor comment tokens and add I2S nodes to device trees".

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (5)

Devices/m5stack-cardputer/m5stack,cardputer.dts (1)

3-6: ⚠️ Potential issue | 🟠 Major

Missing #include <tactility/bindings/esp32_i2s.h> for I2S constants.

The i2s0 node uses I2S_NUM_0 and GPIO_PIN_NONE constants, but the required header is not included. Other device tree files in this PR (e.g., lilygo,tdeck.dts) include this header.

Proposed fix

 `#include` <tactility/bindings/root.h>
 `#include` <tactility/bindings/esp32_gpio.h>
 `#include` <tactility/bindings/esp32_i2c.h>
+#include <tactility/bindings/esp32_i2s.h>

Devices/m5stack-cardputer-adv/m5stack,cardputer-adv.dts (1)

3-5: ⚠️ Potential issue | 🟠 Major

Missing #include <tactility/bindings/esp32_i2s.h> for I2S constants.

Same issue as m5stack,cardputer.dts - the i2s0 node uses I2S_NUM_0 and GPIO_PIN_NONE constants without including the required header.

Proposed fix

 `#include` <tactility/bindings/root.h>
 `#include` <tactility/bindings/esp32_gpio.h>
 `#include` <tactility/bindings/esp32_i2c.h>
+#include <tactility/bindings/esp32_i2s.h>

Devices/m5stack-cores3/m5stack,cores3.dts (1)

3-5: ⚠️ Potential issue | 🟠 Major

Missing #include <tactility/bindings/esp32_i2s.h> for I2S constants.

The i2s0 node uses I2S_NUM_0 constant without including the required header.

Proposed fix

 `#include` <tactility/bindings/root.h>
 `#include` <tactility/bindings/esp32_gpio.h>
 `#include` <tactility/bindings/esp32_i2c.h>
+#include <tactility/bindings/esp32_i2s.h>

Devices/lilygo-tlora-pager/lilygo,tlora-pager.dts (1)

3-5: ⚠️ Potential issue | 🟠 Major

Missing #include <tactility/bindings/esp32_i2s.h> for I2S constants.

The i2s0 node uses I2S_NUM_0 constant without including the required header.

Proposed fix

 `#include` <bindings/tlora_pager.h>
 `#include` <tactility/bindings/esp32_gpio.h>
 `#include` <tactility/bindings/esp32_i2c.h>
+#include <tactility/bindings/esp32_i2s.h>

Devices/m5stack-core2/m5stack,core2.dts (1)

3-5: ⚠️ Potential issue | 🟠 Major

Missing #include <tactility/bindings/esp32_i2s.h> for I2S constants.

The i2s0 node uses I2S_NUM_0 and GPIO_PIN_NONE constants without including the required header.

Proposed fix

 `#include` <tactility/bindings/root.h>
 `#include` <tactility/bindings/esp32_gpio.h>
 `#include` <tactility/bindings/esp32_i2c.h>
+#include <tactility/bindings/esp32_i2s.h>