Preserve library RT coordinates and calibrate search dimensions independently - #148
Merged
Merged
Conversation
jspaezp
commented
Sep 24, 2026
| pub rt_range_seconds: [f64; 2], | ||
| /// Input-axis descriptor supplied by the library consumer. The fitter maps | ||
| /// numerical library coordinates to observed seconds without interpreting units. | ||
| pub library_rt_axis: serde_json::Value, |
Collaborator
Author
There was a problem hiding this comment.
for sure type this ...
jspaezp
commented
Sep 24, 2026
Apex-finder bench
Sensitivity + timing across canonical scenarioscommit 245d852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library RT was treated as acquisition seconds, and a failed RT fit prevented m/z and mobility calibration. This change preserves the source RT domain and calibrates searchable dimensions independently.
c033092. JSON loading and prediction preserve explicit axes and declared scales.LibraryRT<f32>. A borrowedExtractionQuerycarries separately resolvedObservedRTSeconds<f32>bounds. Collectors own reusable buffers and retain no library lifetime. Index calls acceptPeakTolerance; RT is resolved once, preserving existing tolerance arithmetic.Validation:
-D warnings -A clippy::too_many_arguments; the argument-count exception covers existing CLI/viewer/Python signatures. Dashboard feature checks,task fmtandgit diff --checkpassed.ZeroRange; full run with m/z calibrationShuffled RT exposes an existing estimator limitation: the fitter accepts a monotonic path through noise. Its ridge half-width averages 411 s versus 96 s for intact RT. Fit-quality rejection remains separate work; no scientific threshold is added here. These estimated q-value counts on one acquisition do not establish independent FDR accuracy or the 1,000-file storage requirement.
Closes #115.
Follow-up work: