Add Cartesian axis title styling - #121
Open
wojtekmaj wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (31)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughCartesian axis titles now support configurable ChangesStyled Cartesian axis titles
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This additive axis-title styling change preserves existing defaults and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant ChartConfig
participant SceneLayout
participant SVGRenderer
participant CanvasRenderer
participant NativeRenderer
ChartConfig->>SceneLayout: provide styled axis label
SceneLayout->>SceneLayout: measure configured font size and weight
SceneLayout->>SVGRenderer: pass resolved label
SceneLayout->>CanvasRenderer: pass resolved label
SceneLayout->>NativeRenderer: pass resolved label
SVGRenderer-->>ChartConfig: render styled SVG title
CanvasRenderer-->>ChartConfig: paint styled Canvas title
NativeRenderer-->>ChartConfig: render styled native title
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 13 files. (18 skipped: 18 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the object form of
axis.labelwithfontSize,fontWeight,fill, andopacity;fillfollows the existing scene-text paint vocabulary and represents the title color. String labels and omitted fields preserve the current typography, theme foreground, and 0.76 opacity. The options resolve into the shared scene label before measurement, so automatic offsets and margins account for configured typography across SVG, Canvas, React Native, facets, and motion.Adds focused renderer and layout coverage, reference documentation, and a composed-chart catalog example. The API covers downstream dashboard title styling without a custom renderer or CSS override.
Bundle impact is 169 minified bytes / 29 gzip bytes on the locked line + static SVG consumer. The dedicated styled-title fixture adds 0.06 KiB gzip and no retained modules over that consumer;
pnpm bundle:checkreproduces the measurement. No dependency was added.Closes #93.
Summary by CodeRabbit
New Features
Documentation