Skip to content

fixed unnecessary string() call - #391

Merged
tannerlinsley merged 3 commits into
TanStack:mainfrom
Christopher96u:fix/t3env-zod
Nov 1, 2026
Merged

tannerlinsley merged 3 commits into
TanStack:mainfrom
Christopher96u:fix/t3env-zod

Conversation

@Christopher96u

@Christopher96u Christopher96u commented Feb 20, 2026 •

Copy link
Copy Markdown
Contributor

Fixed unnecessary string() call because in zod v4 it's deprecated (solidjs version already has this change)

Summary by CodeRabbit

  • Bug Fixes
    • Updated validation for the optional server URL setting to use the current URL validator. The setting remains optional, and its expected value and behavior are unchanged. This keeps URL validation consistent with the corresponding setting in the Solid add-on.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4c7d21d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@tanstack/create Patch
create-start-app Patch
create-tanstack-app Patch
create-tanstack Patch
create-tsrouter-app Patch
@tanstack/create-start Patch
@tanstack/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 769aba74-4e50-4c42-ac02-f1071a7fee2b
Commits

Reviewing files that changed from the base of the PR and between 44a4aab and 4c7d21d.

Files selected for processing: 1
  • .changeset/t3env-zod-url.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The React T3Env add-on now validates the optional SERVER_URL field with z.url(). A patch changeset records the update for @tanstack/create.

Changes: SERVER_URL schema

Layer / File(s) Summary
Update URL validation
packages/create/src/frameworks/react/add-ons/t3env/assets/src/env.ts, .changeset/t3env-zod-url.md
The optional SERVER_URL field now uses z.url() instead of z.string().url(). The changeset records the update.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to 4c7d2

The schema update is compatible with the declared Zod version and does not introduce a merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the main change: removing the unnecessary string() call from the Zod URL schema.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@tannerlinsley
tannerlinsley merged commit d795831 into TanStack:main Nov 1, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants