Skip to content

WIP: Upgrade to solidjs beta.12#7415

Draft
brenelz wants to merge 7 commits into
solid-router-v2-prefrom
upgrade-to-veta.11
Draft

WIP: Upgrade to solidjs beta.12#7415
brenelz wants to merge 7 commits into
solid-router-v2-prefrom
upgrade-to-veta.11

Conversation

@brenelz
Copy link
Copy Markdown
Contributor

@brenelz brenelz commented May 16, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4599a973-6849-41b8-a912-ed4b4993c1e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-to-veta.11

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brenelz brenelz changed the title WIP: Upgrade to veta.11 WIP: Upgrade to beta.12 May 16, 2026
@brenelz brenelz changed the title WIP: Upgrade to beta.12 WIP: Upgrade to solidjs beta.12 May 16, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 16, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 16, 2026

View your CI Pipeline Execution ↗ for commit 2087f9a

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 8m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 47s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-17 02:15:37 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

Bundle Size Benchmarks

  • Commit: b21ee8e603b9
  • Measured at: 2026-05-17T02:08:10.005Z
  • Baseline source: history:32c5a8ec8d19
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.62 KiB +303 B (+0.34%) 276.23 KiB 76.20 KiB ▁▁▁▁▁▂▂▂▂▂▂█
react-router.full 90.93 KiB +74 B (+0.08%) 287.42 KiB 78.92 KiB ▁▁▁▁▁▃▃▃▃▃▃█
solid-router.minimal 41.55 KiB +6.00 KiB (+16.88%) 122.51 KiB 37.59 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 46.09 KiB +5.83 KiB (+14.48%) 136.31 KiB 41.56 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 53.52 KiB +200 B (+0.37%) 153.54 KiB 47.99 KiB ▁▁▁▁▁▂▂▂▂▂▂█
vue-router.full 58.38 KiB -65 B (-0.11%) 169.00 KiB 52.31 KiB ▄▄▄▄▄██████▁
react-start.minimal 102.13 KiB +118 B (+0.11%) 324.47 KiB 88.29 KiB ▁▁▁▁▁▃▃▃▃▃▃█
react-start.full 105.53 KiB +88 B (+0.08%) 334.82 KiB 91.25 KiB ▁▁▁▁▁▃▃▃▃▃▃█
solid-start.minimal 62.72 KiB +13.06 KiB (+26.30%) 190.90 KiB 55.45 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 66.60 KiB +11.16 KiB (+20.13%) 202.43 KiB 58.79 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 16, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7415

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7415

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7415

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7415

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7415

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7415

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7415

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7415

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7415

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7415

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7415

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7415

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7415

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7415

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7415

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7415

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7415

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7415

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7415

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7415

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7415

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7415

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7415

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7415

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7415

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7415

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7415

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7415

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7415

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7415

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7415

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7415

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7415

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7415

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7415

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7415

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7415

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7415

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7415

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7415

commit: 2087f9a

nx-cloud[bot]

This comment was marked as outdated.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 16, 2026

Merging this PR will improve performance by 16.87%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
✅ 2 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
ssr request loop (solid) 174.6 ms 157.8 ms +10.65%
client-side navigation loop (solid) 72.6 ms 51.4 ms +41.41%
client-side navigation loop (react) 56.3 ms 53.6 ms +5.05%
client-side navigation loop (vue) 83 ms 73.1 ms +13.5%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing upgrade-to-veta.11 (2087f9a) with solid-router-v2-pre (67a9040)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (1cd6afb) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We fixed a cache-corruption bug introduced by the new matchedRoutesCache in router-core/src/router.ts. The cached routeParams object was being mutated in-place by Object.assign(routeParams, strictParams) in matchRoute, causing subsequent cache hits to return already-parsed params (e.g. { postId: '2', status: 'parsed' }) as the raw input to parseParams instead of the original URL params ({ postId: '2' }). Returning a fresh copy of routeParams on cache hits prevents this mutation from propagating back into the cache, fixing the failing unit tests across @tanstack/react-router, @tanstack/vue-router, and @tanstack/solid-router.

Tip

We verified this fix by re-running @tanstack/react-router:test:unit, @tanstack/solid-router:test:unit, @tanstack/vue-router:test:unit.

Warning

The suggested diff is too large to display here, but you can view it on Nx Cloud ↗


Apply fix via Nx Cloud  Reject fix via Nx Cloud


Or Apply changes locally with:

npx nx-cloud apply-locally yJni-iCyH

Apply fix locally with your editor ↗   View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant