Skip to content

fix(start-plugin-core): keep prerender trailing slash off the query string #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjsewell wants to merge 1 commit into from
+8 −1
Closed

fix(start-plugin-core): keep prerender trailing slash off the query string #7838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/prerender-trailing-slash-query.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@tanstack/start-plugin-core': patch
---

fix(start-plugin-core): keep the prerender trailing slash off the query string

The crawler applied `withTrailingSlash` to the full path including the query string, so the slash landed inside the last search-param value and, with `crawlLinks` enabled, sent the crawl into an infinite loop. Passing ufo's `respectQueryAndFragment` flag keeps the slash on the path.
2 changes: 1 addition & 1 deletion packages/start-plugin-core/src/prerender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export async function prerender({

try {
const res = await requestWithRedirects(
withTrailingSlash(withBase(page.path, routerBasePath)),
withTrailingSlash(withBase(page.path, routerBasePath), true),
{
headers: {
...(prerenderOptions.headers ?? {}),
Expand Down