Skip to content

fix: add missing column order memo deps #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinVandy merged 1 commit into from
Jun 4, 2026
+55 −1
Merged

fix: add missing column order memo deps #6293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/table-core/src/features/column-pinning/columnPinningFeature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,20 +283,23 @@ export function constructColumnPinningFeature<
memoDeps: () => [
table.options.columns,
table.atoms.columnPinning?.get(),
table.atoms.columnOrder?.get(),
],
},
table_getRightLeafColumns: {
fn: () => table_getRightLeafColumns(table),
memoDeps: () => [
table.options.columns,
table.atoms.columnPinning?.get(),
table.atoms.columnOrder?.get(),
],
},
table_getCenterLeafColumns: {
fn: () => table_getCenterLeafColumns(table),
memoDeps: () => [
table.options.columns,
table.atoms.columnPinning?.get(),
table.atoms.columnOrder?.get(),
],
},
table_getPinnedLeafColumns: {
Expand All @@ -310,6 +313,7 @@ export function constructColumnPinningFeature<
table.options.columns,
table.atoms.columnPinning?.get(),
table.atoms.columnVisibility?.get(),
table.atoms.columnOrder?.get(),
],
},
table_getCenterVisibleLeafColumns: {
Expand All @@ -318,6 +322,7 @@ export function constructColumnPinningFeature<
table.options.columns,
table.atoms.columnPinning?.get(),
table.atoms.columnVisibility?.get(),
table.atoms.columnOrder?.get(),
],
},
table_getRightVisibleLeafColumns: {
Expand All @@ -326,6 +331,7 @@ export function constructColumnPinningFeature<
table.options.columns,
table.atoms.columnPinning?.get(),
table.atoms.columnVisibility?.get(),
table.atoms.columnOrder?.get(),
],
},
table_getPinnedVisibleLeafColumns: {
Expand Down
50 changes: 49 additions & 1 deletion packages/table-core/tests/unit/features/column-pinning/columnPinningFeature.utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ import {
table_resetColumnPinning,
table_setColumnPinning,
} from '../../../../src/static-functions'
import { generateTestTableWithData } from '../../../helpers/generateTestTable'
import {
generateTestTableWithData,
generateTestTableWithDataAndState,
} from '../../../helpers/generateTestTable'
import { getUpdaterResult } from '../../../helpers/testUtils'
import type { Header } from '../../../../src'

Expand Down Expand Up @@ -659,6 +662,51 @@ describe('column pinning table instance APIs', () => {

expect(table.getColumn('firstName')!.getStart('left')).toBe(0)
})

it('should update center visible columns when column order changes', () => {
const table = generateTestTableWithDataAndState(1, {
_features: stockFeatures,
})

expect(
table.getCenterVisibleLeafColumns().map((col: { id: string }) => col.id),
).toEqual([
'id',
'firstName',
'lastName',
'age',
'visits',
'progress',
'status',
'subRows',
])
expect(table.getColumn('lastName')!.getStart('center')).toBe(300)

table.setColumnOrder([
'lastName',
'firstName',
'id',
'age',
'visits',
'progress',
'status',
'subRows',
])

expect(
table.getCenterVisibleLeafColumns().map((col: { id: string }) => col.id),
).toEqual([
'lastName',
'firstName',
'id',
'age',
'visits',
'progress',
'status',
'subRows',
])
expect(table.getColumn('lastName')!.getStart('center')).toBe(0)
})
})

describe('table_getFooterGroups', () => {
Expand Down
Loading