You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: guard root loader data in page view tracker and isolate live config failures - #1491
PageViewTracker runs directly inside the root shellComponent. TanStack Router mounts shellComponent even when the root loader fails or is still pending (because the shell also wraps the route's errorComponent).
Previously, PageViewTracker immediately destructured { live } = Route.useLoaderData(). When the root loader had no resolved data (such as when getLiveRuntimeConfig() threw or timed out during server function evaluation), Route.useLoaderData() returned undefined, causing an uncaught TypeError: Cannot destructure property 'live' of 'ue.useLoaderData(...)' as it is undefined that crashed the entire application.
Fix
Guard Route.useLoaderData() in PageViewTracker (src/routes/__root.tsx): Safely access Route.useLoaderData()?.live and derive boolean flags (live?.presenceEnabled === true, live?.chatEnabled === true). This ensures core page view analytics and Scarf interaction listeners continue to work even when root loader data is unavailable.
Isolate optional live runtime config in root loader: Wrapped getLiveRuntimeConfig() in a helper that catches failures, logs them via Sentry.captureException(error, { tags: { feature: 'live-config' } }), and falls back to disabling presence and chat features so that failures in non-critical live configuration never break the root route or send the entire site into an error boundary.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
PageViewTrackerruns directly inside the rootshellComponent. TanStack Router mountsshellComponenteven when the root loader fails or is still pending (because the shell also wraps the route'serrorComponent).Previously,
PageViewTrackerimmediately destructured{ live } = Route.useLoaderData(). When the root loader had no resolved data (such as whengetLiveRuntimeConfig()threw or timed out during server function evaluation),Route.useLoaderData()returnedundefined, causing an uncaughtTypeError: Cannot destructure property 'live' of 'ue.useLoaderData(...)' as it is undefinedthat crashed the entire application.Fix
Route.useLoaderData()inPageViewTracker(src/routes/__root.tsx): Safely accessRoute.useLoaderData()?.liveand derive boolean flags (live?.presenceEnabled === true,live?.chatEnabled === true). This ensures core page view analytics and Scarf interaction listeners continue to work even when root loader data is unavailable.getLiveRuntimeConfig()in a helper that catches failures, logs them viaSentry.captureException(error, { tags: { feature: 'live-config' } }), and falls back to disabling presence and chat features so that failures in non-critical live configuration never break the root route or send the entire site into an error boundary.Fixes TANSTACK-COM-5F7
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.