fix(angular-virtual): remove deprecated effect option

[ousamabenyounes]

Changes

Fixes #1058.

Problem

Angular 20 logs a deprecation warning when the affected examples load because they still pass allowSignalWrites: true to effect.

Fix

• Removed the deprecated effect option from the Angular padding, dynamic, and infinite-scroll examples.
• Added an Angular e2e guard that fails if source examples reintroduce allowSignalWrites: true.

Test verification (RED -> GREEN)

RED:

• Browser verification against the Angular infinite-scroll example logged the deprecated allowSignalWrites warning before the fix.
• The new guard was run with the example edits reverted and failed, listing all eight affected Angular source files.

GREEN:

• Browser verification against the same example no longer logged the deprecated warning after the fix.
• The new guard passes with the fix applied.

Full local suite proof

• Baseline upstream main: pnpm run test:ci passed.
• Final patched tree: pnpm exec nx run-many --parallel=1 --targets=test:sherif,test:knip,test:docs,test:eslint,test:lib,test:e2e,test:types,test:build,build passed.

The final full local suite used Nx parallelism of 1 to avoid local browser-resource flakes seen during the high-concurrency attempt. The command covers the same target matrix as pnpm run test:ci.

Release impact

• Published package code changed
• Examples or tests only

No changeset is included because this only updates examples and test coverage.

Summary by CodeRabbit

• Refactor

  • Updated Angular examples to use default effect options while preserving existing measurement and data-fetching behavior.
  • Simplified effect declarations for improved readability.

• Tests

  • Added end-to-end coverage that detects deprecated effect options in Angular example files.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 49fb144e-6534-4f40-9720-c435a41b55e5

📥 Commits

Reviewing files that changed from the base of the PR and between 789f5c2 and a713432.

📒 Files selected for processing (9)

• examples/angular/dynamic/src/app/column-virtualizer-dynamic.component.ts
• examples/angular/dynamic/src/app/grid-virtualizer-dynamic.component.ts
• examples/angular/dynamic/src/app/row-virtualizer-dynamic-window.component.ts
• examples/angular/dynamic/src/app/row-virtualizer-dynamic.component.ts
• examples/angular/infinite-scroll/src/app/app.component.ts
• examples/angular/padding/src/app/column-virtualizer-padding.component.ts
• examples/angular/padding/src/app/grid-virtualizer-padding.component.ts
• examples/angular/padding/src/app/row-virtualizer-padding.component.ts
• packages/angular-virtual/e2e/app/test/no-deprecated-effect-options.spec.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

Angular examples remove the deprecated allowSignalWrites: true option from effects. Their measurement and pagination logic remains unchanged. A Playwright test scans Angular example TypeScript files for remaining usage.

Changes

Angular effect option cleanup

Layer / File(s)	Summary
Remove deprecated effect options examples/angular/dynamic/src/app/*.component.ts, examples/angular/padding/src/app/*.component.ts, examples/angular/infinite-scroll/src/app/app.component.ts	Measurement and pagination effects no longer pass allowSignalWrites: true. Their existing callbacks remain unchanged.
Validate Angular examples packages/angular-virtual/e2e/app/test/no-deprecated-effect-options.spec.ts	A Playwright test scans Angular example TypeScript files and fails when deprecated option usage is found.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to a7134

Angular examples no longer emit the deprecated effect-option warning while retaining their existing measurement and infinite-scroll behavior. The source guard prevents this option from being reintroduced, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: removing the deprecated Angular effect option.
Description check	✅ Passed	The description explains the problem, fix, testing, and release impact. It omits the repository checklist items, but it is otherwise complete and directly related to the changes.
Linked Issues check	✅ Passed	The changes satisfy issue [#1058] by removing allowSignalWrites: true from the affected Angular examples and preventing its reintroduction with an end-to-end guard.
Out of Scope Changes check	✅ Passed	All changes are within scope. They update the affected Angular examples and add targeted test coverage for the deprecated option.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 9…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}