[0.3.7 ISSUE-3297 & 3469] Fixed Issue with FIFA dataset validation - "null"#60
Merged
[0.3.7 ISSUE-3297 & 3469] Fixed Issue with FIFA dataset validation - "null"#60
Conversation
## Dev Board Ticket - https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3297 ## Changes - Bumped package version from `0.3.6` to `0.3.7`. - Updated `CHANGELOG.md` with `0.3.7 (2026-04-29)` entry based on current changes. - Added upfront null/NaN placeholder detection in feature `properties` before schema validation (including string placeholders like `"null"` / `"nan"`). - Improved validation message clarity: - Enum errors now use actionable field-level wording. - Type errors now use actionable datatype wording. - Enum value previews now show up to 5 values with `|` separator and `and N more` for long lists. - Removed field-specific enum hardcoding and made enum formatting generic/schema-driven. - Changed issues collection behavior to keep detailed per-feature issues and suppress noisy `AnyOf` summaries when specific field errors exist for the same feature. - Enforced consistent capping for both `errors` and `issues`: - Default cap: `20` - Override supported via `validate(max_errors=...)` - Updated README to reflect current behavior: - null/NaN precheck, - detailed `issues` behavior, - capping semantics for `errors` and `issues`, - enum preview formatting. ## Testing and unit test cases - ISSUE-3297 (`tests/assets/issue_3297.zip`) expected issue payload. - Nullish precheck behavior before schema validation test cases. - `issues` cap default and `max_errors` override behavior test case. - Updated helper unit test cases for formatting expectations for new message styles.
sujata-m
changed the title
MashB
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
Changes
0.3.6to0.3.7.CHANGELOG.mdwith0.3.7 (2026-04-29)entry based on current changes.propertiesbefore schema validation (including string placeholders like"null"/"nan").|separator andand N morefor long lists.AnyOfsummaries when specific field errors exist for the same feature.errorsandissues:20validate(max_errors=...)issuesbehavior,errorsandissues,Testing and unit test cases
tests/assets/issue_3297.zip) expected issue payload.issuescap default andmax_errorsoverride behavior test case.