Refactor indexer to trigger subsystem and update related components#33
Open
PillageDev wants to merge 1 commit intodevelopfrom
Open
Refactor indexer to trigger subsystem and update related components#33PillageDev wants to merge 1 commit intodevelopfrom
PillageDev wants to merge 1 commit intodevelopfrom
Conversation
afranchuk
approved these changes
Feb 25, 2026
Contributor
|
What is this pull request about? What is the purpose? Please fill out the description |
bjmcternan
reviewed
Feb 25, 2026
| if (proximitySensor.get()) { | ||
| triggerIO.setSpeed(0.0); | ||
| } else { | ||
| triggerIO.setSpeed(triggerSpeed); |
Contributor
There was a problem hiding this comment.
Won't this have the trigger on all the time?
bjmcternan
requested changes
Feb 25, 2026
Contributor
bjmcternan
left a comment
bjmcternan
left a comment
There was a problem hiding this comment.
Activating when there's a ball present means we're pushing balls up all the time. I'm not sure this logic is correct
bjmcternan
reviewed
Feb 25, 2026
| @AutoLog | ||
| public static class IndexerIOInputs extends BaseInputClass { | ||
| public static class TriggerIOInputs extends BaseInputClass { | ||
| public double motorRps = 0.0; |
Contributor
There was a problem hiding this comment.
Add the prox sensor reading as well
bjmcternan
reviewed
Feb 25, 2026
| this.vision = new Vision(drivetrain); | ||
| this.intake = new Intake(drivetrain); | ||
| this.indexer = new Indexer(2); | ||
| this.trigger = new Trigger(2); |
Contributor
There was a problem hiding this comment.
Let's not use a magic number here. Let's make this a final value
bjmcternan
reviewed
Feb 25, 2026
Contributor
There was a problem hiding this comment.
I'm not seeing a method for "firing" or not. Shouldn't we have that here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the indexer class to trigger class, which is the correct name of the mechanism