Conversation
Yoepee
approved these changes
Jul 3, 2025
Member
Yoepee
left a comment
There was a problem hiding this comment.
이번에 map에서 merge 메소드 쓰는 법을 배운게 정말 좋았던 것 같습니다.
백엔드 개발자는 정말 문서를 많이 씁니다...
주석을 디테일하게 달아서 협업하는 연습을 하는 것도 중요하다고 생각합니다.
간결한 코드 잘 봤습니다.
LGTM~
Author
주석을 안쓰고 최대한 가독성이 좋은 코드를 작성하는 방향으로 코드를 짜왔는데, 다른 분들도 주석에 대한 생각을 리마인드 할 수 있게 CleanCode 4장 주석 관련 내용 참고하시면 좋을 것 같습니다! // 좋은 주석의 한 예 (의도를 설명하는 주석)
// 스레드를 대량 생성하는 방법으로 어떻게든 경쟁 조건을 만들려 시도한다.
for (int i = 0; i > 2500; i++) {
WidgetBuilderThread widgetBuilderThread =
new WidgetBuilderThread(widgetBuilder, text, parent, failFlag);
Thread thread = new Thread(widgetBuilderThread);
thread.start();
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
팀장님 말씀대로 덕분에 git 연습하기 좋았습니다.