Improve command-buffer bake efficiency and add inspect chain helper#1
Open
Improve command-buffer bake efficiency and add inspect chain helper#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
finishfaster and safer.Description
drain(..).collect()uses for extracting tasks/controllers withstd::mem::taketo avoid extra allocations and drains inTaskChain::chain_semaphoresandTaskChain::get_controllers(src/command_buffers/buffer.rs).RawCommandBuffer::finishto take&mut self, removed the internal unsafe self-mutation, precomputed the final task capacity, and incrementally extend the output vector to avoid an extra intermediate collect step (src/command_buffers/buffer.rs).Inspect<T>with a chainable method.inspect(...)that runs a side-effect taking&Tand returns the original value unchanged, enabling non-intrusive inspection in command chains (src/command_buffers/commands.rs).buffer.rs/commands.rs).Testing
cargo test --all-features, which completed successfully (unit tests and doc-tests passed).Codex Task