Skip to content

[ruby/agoo] Marked as broken#10748

Closed
joanhey wants to merge 1 commit intoTechEmpower:masterfrom
joanhey:patch-2
Closed

[ruby/agoo] Marked as broken#10748
joanhey wants to merge 1 commit intoTechEmpower:masterfrom
joanhey:patch-2

Conversation

@joanhey
Copy link
Contributor

@joanhey joanhey commented Feb 13, 2026

@p8
Copy link
Contributor

p8 commented Feb 13, 2026

@joanhey Yes, thanks, I'm aware of it but hadn't had time to fix it.
#10750

There probably are other frameworks that have been failing for a longer time.
I think @volyrique only marked frameworks as broken if the test failed for 10 runs.

@volyrique
Copy link
Contributor

The value that the TechEmpower team has set in the tfb-fail-detector.py script is 3.

The reason why I chose 11 was because I couldn't be bothered to research the people that had to be pinged for 60 implementations, so I focused on code that hadn't been changed in years, that had been failing for 3 months or more, and that had no maintainers set in its configuration file. In other words, implementations that for all intents and purposes have been abandonеd and nobody cares about.

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

For me it's worst.
I try to mark as broken all than fail, and I use my time to identify the devs, to inform them.
And later I ask they add the maintainers, but the bad is me !!!

If anybody don't want to add the maintainers, for me it's OK, but the next time I will not spent my time !!
And the fw will be marked as broken directly !!

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

This was added some years ago, because I ask it.
But almost no framework maintainer know it !!

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

I think that is failing, for more than 3 runs, we need to check it.
If the fail it's about not to network, limits in github or dockerhub, .... we need to gain time for the runs.
Thank you !!

@volyrique
Copy link
Contributor

This was added some years ago, because I ask it. But almost no framework maintainer know it !!

To be fair, some people may simply prefer not to be spammed with notifications. I have added myself in only one place, even though I have contributed to a couple of other implementations because I don't truly care about them (but so far I have fixed them if necessary).

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

I want to create a new issue for the toolset.
Now the runs mix the 2 problems: don't start or stop and failing a test.
This need to be changed, the fw than don't start need to be show separately.

And still better, have a page for the fw failing, when (time), how much, ....
Because it's very important know when start to fail.

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

@volyrique I understand you.
But the same than you, another people are angry when we marked as broken, and nobody is notified.

The problem is that the fw can fail for years, without any benefit, and the runs now need more than 1 week.

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

Now checking the actual run, Cutelyst is terrible, only this framework need more than 12 hours only for build, later tests and bench.
And have more than 10 mutations !!!

@volyrique
Copy link
Contributor

We have issue #10238 for that.

@joanhey
Copy link
Contributor Author

joanhey commented Feb 13, 2026

They (we) need to automatize more, if a framework have more than 10 mutations, explain it with a github action.
If json/plaintext are separate from the database tests, notify it with a github action.
No maintainers, explain about it, not mandatory, but later don't cry if your fw is marked as broken without any notification !!

@p8
Copy link
Contributor

p8 commented Feb 16, 2026

@joanhey can you close this PR in favor of: #10750 ?

@joanhey
Copy link
Contributor Author

joanhey commented Feb 16, 2026

#10750

@joanhey joanhey closed this Feb 16, 2026
@p8
Copy link
Contributor

p8 commented Feb 16, 2026

Thanks @joanhey !

@joanhey
Copy link
Contributor Author

joanhey commented Feb 16, 2026

Of course !!

@joanhey
Copy link
Contributor Author

joanhey commented Feb 16, 2026

But I said before, the next time I'll not close a PR.
They start with the older PRs and later with the new.
And it is NOT our work this !!!

@joanhey joanhey deleted the patch-2 branch February 20, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants