Skip to content

Chronos-historytimelines#156

Open
SaraEnderborg wants to merge 36 commits intoTechnigo:mainfrom
SaraEnderborg:main
Open

Chronos-historytimelines#156
SaraEnderborg wants to merge 36 commits intoTechnigo:mainfrom
SaraEnderborg:main

Conversation

@SaraEnderborg
Copy link
Copy Markdown

- Add war.query.js, war.mapper.js, war.job.js
- Add medicine.query.js, medicine.mapper.js, medicine.job.js
- Add shared _mapperUtils.js (extractQid, buildEventDoc)
- Add shared _runImport.js (runImport, startFromCLI)
- Fix event query overlap logic in layers.service.js
- War import verified: 1333 events upserted to MongoDB
- Medicine import pending: query needs debugging
- Add TimelinePage with horizontal timeline visualization
- Add EventDot, TimelineRow, EventPanel, YearAxis, LayerSelector components
- Add CSS modules for all timeline components
- Add AppLayout with navbar
- Add React Router, React Query, Zustand wiring
- Fix API URL and response parsing
- Separate Wikidata queries per medicine subcategory
- Remove label-based category guessing
- Assign fixed category per import task
- Improve data clarity and pedagogical structure
- move shared SPARQL helpers to queries/_shared.js
- fix war.job per-category error handling
- remove invalid medicine task placeholder
- add dotenv loading for CLI import jobs
- verify war + medicine imports with dry-run
Copy link
Copy Markdown
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with this project Sara! I'm impressed with how it all came together. Your project is structured and overall clean (there's some unused/unfinished code, and some inconsistencies). However, you've met most of the requirements and you have some really nice functionality going on here. The only requirement I can see that's not met is 100% Lighthouse score (Touch targets do not have sufficient size or spacing) - so that could be something to think about. But I'll approve this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants