Skip to content

feat: Add CERT record-type (rfc4398) support #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
readefries wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add CERT record-type (rfc4398) support #1882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions DnsServerCore/WebServiceZonesApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,23 @@ private static void WriteRecordAsJson(DnsResourceRecord record, Utf8JsonWriter j
}
break;

case DnsResourceRecordType.CERT:
{
if (record.RDATA is DnsCERTRecordData rdata)
{
jsonWriter.WriteString("certType", rdata.CertType.ToString());
jsonWriter.WriteNumber("keyTag", rdata.KeyTag);
jsonWriter.WriteNumber("algorithm", rdata.Algorithm);
jsonWriter.WriteString("certificate", Convert.ToBase64String(rdata.Certificate));
}
else
{
jsonWriter.WriteString("dataType", record.RDATA.GetType().Name);
jsonWriter.WriteString("data", record.RDATA.ToString());
}
}
break;

case DnsResourceRecordType.RRSIG:
{
if (record.RDATA is DnsRRSIGRecordData rdata)
Expand Down Expand Up @@ -4003,6 +4020,17 @@ public void AddRecord(HttpContext context)
}
break;

case DnsResourceRecordType.CERT:
{
DnsCertType certType = Enum.Parse<DnsCertType>(request.GetQueryOrForm("certType").Replace('-', '_'), true);
ushort certKeyTag = request.GetQueryOrForm("certKeyTag", ushort.Parse);
byte certAlgorithm = request.GetQueryOrForm("certAlgorithm", byte.Parse);
byte[] certificate = request.GetQueryOrForm("certificate", Convert.FromBase64String);

newRecord = new DnsResourceRecord(domain, type, DnsClass.IN, ttl, new DnsCERTRecordData(certType, certKeyTag, certAlgorithm, certificate));
}
break;

case DnsResourceRecordType.TLSA:
{
DnsTLSACertificateUsage tlsaCertificateUsage = Enum.Parse<DnsTLSACertificateUsage>(request.GetQueryOrForm("tlsaCertificateUsage").Replace('-', '_'), true);
Expand Down Expand Up @@ -4428,6 +4456,18 @@ public void DeleteRecord(HttpContext context)
}
break;

case DnsResourceRecordType.CERT:
{
DnsCertType certType = Enum.Parse<DnsCertType>(request.GetQueryOrForm("certType").Replace('-', '_'), true);
ushort certKeyTag = request.GetQueryOrForm("certKeyTag", ushort.Parse);
byte certAlgorithm = request.GetQueryOrForm("certAlgorithm", byte.Parse);
byte[] certificate = request.GetQueryOrForm("certificate", Convert.FromBase64String);

if (!_dnsWebService._dnsServer.AuthZoneManager.DeleteRecord(zoneInfo.Name, domain, type, new DnsCERTRecordData(certType, certKeyTag, certAlgorithm, certificate)))
throw new DnsWebServiceException("Cannot delete record: no such record exists.");
}
break;

case DnsResourceRecordType.TLSA:
{
DnsTLSACertificateUsage tlsaCertificateUsage = Enum.Parse<DnsTLSACertificateUsage>(request.GetQueryOrForm("tlsaCertificateUsage").Replace('-', '_'), true);
Expand Down Expand Up @@ -4892,6 +4932,25 @@ public void UpdateRecord(HttpContext context)
}
break;

case DnsResourceRecordType.CERT:
{
DnsCertType certType = Enum.Parse<DnsCertType>(request.GetQueryOrForm("certType").Replace('-', '_'), true);
DnsCertType newCertType = Enum.Parse<DnsCertType>(request.GetQueryOrForm("newCertType", certType.ToString()).Replace('-', '_'), true);

ushort certKeyTag = request.GetQueryOrForm("certKeyTag", ushort.Parse);
ushort newCertKeyTag = request.GetQueryOrForm("newCertKeyTag", ushort.Parse, certKeyTag);

byte certAlgorithm = request.GetQueryOrForm("certAlgorithm", byte.Parse);
byte newCertAlgorithm = request.GetQueryOrForm("newCertAlgorithm", byte.Parse, certAlgorithm);

byte[] certificate = request.GetQueryOrForm("certificate", Convert.FromBase64String);
byte[] newCertificate = request.GetQueryOrForm("newCertificate", Convert.FromBase64String, certificate);

oldRecord = new DnsResourceRecord(domain, type, DnsClass.IN, 0, new DnsCERTRecordData(certType, certKeyTag, certAlgorithm, certificate));
newRecord = new DnsResourceRecord(newDomain, type, DnsClass.IN, ttl, new DnsCERTRecordData(newCertType, newCertKeyTag, newCertAlgorithm, newCertificate));
}
break;

case DnsResourceRecordType.TLSA:
{
DnsTLSACertificateUsage tlsaCertificateUsage = Enum.Parse<DnsTLSACertificateUsage>(request.GetQueryOrForm("tlsaCertificateUsage").Replace('-', '_'), true);
Expand Down