guard app.setName in setupStealth to prevent crash#13
Open
surajmalthumkar8 wants to merge 1 commit intoTechyCSR:mainfrom
Open
guard app.setName in setupStealth to prevent crash#13surajmalthumkar8 wants to merge 1 commit intoTechyCSR:mainfrom
surajmalthumkar8 wants to merge 1 commit intoTechyCSR:mainfrom
Conversation
app.setName crashes when ELECTRON_RUN_AS_NODE is set in the environment since the electron app module is not available. added a null check so it fails silently instead of killing the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.setName()insetupStealth()ELECTRON_RUN_AS_NODEis set in the environment, the electronappmodule is not available andapp.setName()throws, crashing the whole process before it even reachesapp.whenReady()onAppReady()still sets the name once the app is actually readyHow to reproduce
ELECTRON_RUN_AS_NODE=1in your shell (some tools like VS Code extensions do this)npm startTypeError: Cannot read properties of undefined (reading 'setName')Test plan
app.setNamecall inonAppReady()