fix(compose): bind Keycloak to loopback + harden probe - #303
Merged
Conversation
Follow-up to #300: same Docker publish / default-credential exposure shape Charles flagged for Keycloak :8080. Localhost Keycloak and the dashboard auth profile still work; remote access needs a tunnel or an explicit override. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #300 by @modernitconsultants , who correctly left Keycloak alone in that PR because the auth profile may be used remotely, while calling out the same exposure shape: Docker published ports bypass host firewalls, and Keycloak ships with
KEYCLOAK_ADMIN=admin/KEYCLOAK_ADMIN_PASSWORD=admin.This PR closes that gap:
docker-compose.ymlto127.0.0.1:8080:8080.compose:datastores-loopbackinops/harden/cli/probes/local.mjsto also flag Keycloak:8080on all interfaces.Local Keycloak, dashboard, and booking auth (via
localhost:8080) are unchanged. Anyone who relied on reaching Keycloak from another host must use a tunnel or an explicit publish override.Credit for identifying the issue goes to Charles (#300).
Test plan
docker-compose.ymlKeycloak ports line is127.0.0.1:8080:8080keycloak/8080and fails on all-interfaces / passes on loopbackhttp://localhost:8080