fix(doctor): add --no-wait flag to skip browser extension wait - #275
Open
HoneyTyagii wants to merge 1 commit into
Open
HoneyTyagii wants to merge 1 commit into
HoneyTyagii wants to merge 1 commit into
Conversation
Issue Tencent#265 reports that bsk doctor hangs indefinitely when no browser extension is connected. The default 5s wait for browser extension to connect is unnecessary for agent harnesses that manage the daemon externally (e.g. host-managed setups with BSK_AUTO_START=0). This commit adds a --no-wait flag to bsk doctor that skips the browser-connect wait entirely, returning immediately once the daemon is reachable. This allows agents to run bsk doctor without blocking when no extension is available. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #265
Problem
User reports that
bsk doctorhangs indefinitely when no browser extension is connected. The default 5s wait for browser extension to connect is unnecessary for agent harnesses that manage the daemon externally (e.g. host-managed setups withBSK_AUTO_START=0). Agents invoke shell tools with fixed per-call timeouts, so an unbounded wait means the whole agent turn is consumed with no output.Solution
Add
--no-waitflag tobsk doctorcommand that skips the browser-connect wait entirely. This allows agents to runbsk doctorwithout blocking when no extension is available.Changes
crates/bsk-cli/src/cli/mod.rs: Added--no-waitflag to Doctor commandcrates/bsk-cli/src/main.rs: Updated Doctor dispatch to passno_waittorun()crates/bsk-cli/src/cli/doctor.rs: Updatedrun()andresolve_daemon_state()to acceptno_waitparameter and skip browser wait when trueTesting
Build passes:
cargo check -p bskcompleted successfully.