fix(terminal): support touch scrolling in TUI apps - #49
Merged
Conversation
The previous touch handler called terminal.scrollLines(), which is a no-op on the alternate screen buffer that TUI apps run in, so swiping did nothing inside Claude Code / Codex. Synthesize a wheel event on the xterm root element instead: xterm routes it to the scrollback in the normal buffer, or to SGR mouse sequences / arrow keys in the alternate buffer, which TUIs understand. Enable stdin in the WebView and bridge xterm onData back to the pty via a new 'input' WebView message so the synthesized wheel bytes reach the shell. Keyboard input is unaffected (it goes through the RN IME). Co-Authored-By: Claude <noreply@anthropic.com>
When swiping up in a TUI app to return to the newest content, the native touch scroll of .xterm-viewport bubbled to the WebView page when the alternate buffer was at its top, scrolling the whole page instead of the terminal. Disable native touch-scrolling at the source with touch-action: none on the terminal elements (including .xterm-screen, the actual touch hit-target), so the synthetic WheelEvent remains the sole scroll driver. Works on both iOS WKWebView and Android WebView. Co-Authored-By: Claude <noreply@anthropic.com>
touch-action:none alone is not enough on iOS WKWebView: a passive touchmove still lets the page steal the gesture when the alt buffer is already at its top, so the whole terminal slides instead of the content. Make the scroll touchmove non-passive, call preventDefault (skipping only when text selection is active), disable WebView scrollEnabled, and pin .xterm-viewport overflow so the synthetic WheelEvent remains the only scroll driver. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This extracts the touch-scroll work from #39 onto
dev-1.5.0. The original commits remain authored by Tink (goxofy), with an additional stdin-isolation fix. Viewport sizing is handled independently in #48.Verification
npx tsc --noEmitnpm run format:checkgit diff --checkSupersedes the touch-scroll portion of #39.